From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 958A43858D1E; Mon,  6 Feb 2023 16:33:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 958A43858D1E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1675701207;
	bh=nIYJT3Htiy21EtpGkSxDEIgoCkwLGxJPt1vhJJ+yQBQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Xr9uxNvDZS2uoLPo8a7Dx85csKBRYIeToAy60sRYzlwvdIhZxUCD7HNJqGMcWqsvJ
	 SfRDATl6Zb/pYPJh5R7FgDO85cWR+IbOD/Z2YhuFCQogKaKOMace5XXwEM25J5HFe2
	 HF9C4Z5S+xWXA/0e/exfQnXdoSzzrGRGfPR6dpyI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/107461] [12 Regression] ambiguity error for friend with
 templated constexpr argument
Date: Mon, 06 Feb 2023 16:33:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107461-4-LCIMzWQFVD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107461-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107461-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107461

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:eda24f6c12b6d3777ff3bf3656187e695a3e8dc2

commit r12-9110-geda24f6c12b6d3777ff3bf3656187e695a3e8dc2
Author: Patrick Palka <ppalka@redhat.com>
Date:   Sun Feb 5 21:35:33 2023 -0500

    c++: equivalence of non-dependent calls [PR107461]

    After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent
    CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION_DEC=
L.
    This innocent change revealed that cp_tree_equal doesn't first check
    dependence of a CALL_EXPR before treating a FUNCTION_DECL callee as a
    dependent name, which leads to us incorrectly accepting the first two
    testcases below and rejecting the third:

     * In the first testcase, cp_tree_equal incorrectly returns true for
       the two non-dependent CALL_EXPRs f(0) and f(0) (whose CALL_EXPR_FN
       are different FUNCTION_DECLs) which causes us to treat #2 as a
       redeclaration of #1.

     * Same issue in the second testcase, for f<int*>() and f<char>().

     * In the third testcase, cp_tree_equal incorrectly returns true for
       f<int>() and f<void(*)(int)>() which causes us to conflate the two
       dependent specializations A<decltype(f<int>()(U()))> and
       A<decltype(f<void(*)(int)>()(U()))>.

    This patch fixes this by making called_fns_equal treat two callees as
    dependent names only if the overall CALL_EXPRs are dependent, via a new
    convenience function call_expr_dependent_name that is like dependent_na=
me
    but also checks dependence of the overall CALL_EXPR.

            PR c++/107461

    gcc/cp/ChangeLog:

            * cp-tree.h (call_expr_dependent_name): Declare.
            * pt.cc (iterative_hash_template_arg) <case CALL_EXPR>: Use
            call_expr_dependent_name instead of dependent_name.
            * tree.cc (call_expr_dependent_name): Define.
            (called_fns_equal): Adjust to take two CALL_EXPRs instead of
            CALL_EXPR_FNs thereof.  Use call_expr_dependent_name instead
            of dependent_name.
            (cp_tree_equal) <case CALL_EXPR>: Adjust call to called_fns_equ=
al.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/overload5.C: New test.
            * g++.dg/cpp0x/overload5a.C: New test.
            * g++.dg/cpp0x/overload6.C: New test.

    (cherry picked from commit 31924665c86d47af6b1f22a74f594f2e1dc0ed2d)=