public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107468] std::from_chars doesn't always round to nearest
Date: Mon, 07 Nov 2022 14:17:57 +0000	[thread overview]
Message-ID: <bug-107468-4-fCqC6lR8MX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107468-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107468

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:cb0ceeaee9e041aaac3edd089b07b439621d0f29

commit r13-3755-gcb0ceeaee9e041aaac3edd089b07b439621d0f29
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 7 15:17:21 2022 +0100

    libstdc++: Update from latest fast_float [PR107468]

    The following patch updates from fast_float trunk.  That way
    it grabs two of the 4 LOCAL_PATCHES, some smaller tweaks, to_extended
    cleanups and most importantly fix for the incorrect rounding case,
    PR107468 aka https://github.com/fastfloat/fast_float/issues/149
    Using std::fegetround showed in benchmarks too slow, so instead of
    doing that the patch limits the fast path where it uses floating
    point multiplication rather than integral to cases where we can
    prove there will be no rounding (the multiplication will be exact, not
    just that the two multiplication or division operation arguments are
    exactly representable).

    2022-11-07  Jakub Jelinek  <jakub@redhat.com>

            PR libstdc++/107468
            * src/c++17/fast_float/MERGE: Adjust for merge from upstream.
            * src/c++17/fast_float/LOCAL_PATCHES: Remove commits that were
            upstreamed.
            * src/c++17/fast_float/README.md: Merge from fast_float
            662497742fea7055f0e0ee27e5a7ddc382c2c38e commit.
            * src/c++17/fast_float/fast_float.h: Likewise.
            * testsuite/20_util/from_chars/pr107468.cc: New test.

  parent reply	other threads:[~2022-11-07 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 11:23 [Bug libstdc++/107468] New: " jakub at gcc dot gnu.org
2022-11-01 13:57 ` [Bug libstdc++/107468] " ppalka at gcc dot gnu.org
2022-11-01 20:17 ` ppalka at gcc dot gnu.org
2022-11-07 14:17 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-07 14:20 ` jakub at gcc dot gnu.org
2022-11-07 16:53 ` redi at gcc dot gnu.org
2022-11-24  9:39 ` cvs-commit at gcc dot gnu.org
2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107468-4-fCqC6lR8MX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).