public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/107468] New: std::from_chars doesn't always round to nearest Date: Mon, 31 Oct 2022 11:23:46 +0000 [thread overview] Message-ID: <bug-107468-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107468 Bug ID: 107468 Summary: std::from_chars doesn't always round to nearest Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: jakub at gcc dot gnu.org Target Milestone: --- #include <cfenv> #include <charconv> #include <iostream> #include <string_view> int main() { float f; char buf[] = "3.355447e+07"; fesetround(FE_DOWNWARD); auto [ptr, ec] = std::from_chars(buf, buf + sizeof (buf) - 1, f, std::chars_format::scientific); char buf2[128]; auto [ptr2, ec2] = std::to_chars(buf2, buf2 + 128, f, std::chars_format::fixed); std::cout << std::string_view(buf2, ptr2 - buf2) << std::endl; } 33554470 isn't representable in IEEE single, only 33554468 and 33554472 are, the former is 0x1.000012p+25 and the latter is 0x1.000014p+25 and the latter has 0 as the least significant digit. So, round to even should be 33554472 and that is what happens without the fesetround(FE_DOWNWARD). When fast_float isn't used, floating_from_chars.cc temporarily overrides the rounding to nearest, but when it is used, it doesn't. In most cases it is fine, because fast_float usually computes the mantissa and exponent in integral code. But it has two exceptions for this I think. One is the fast path: // Next is Clinger's fast path. if (binary_format<T>::min_exponent_fast_path() <= pns.exponent && pns.exponent <= binary_format<T>::max_exponent_fast_path() && pns.mantissa <=binary_format<T>::max_mantissa_fast_p ath() && !pns.too_many_digits) { value = T(pns.mantissa); if (pns.exponent < 0) { value = value / binary_format<T>::exact_power_of_ten(-pns.exponent); } else { value = value * binary_format<T>::exact_power_of_ten(pns.exponent); } if (pns.negative) { value = -value; } return answer; } I'm afraid we need to temporarily override rounding to nearest around the multiplications in there. And the other one is: T b; to_float(false, am_b, b); adjusted_mantissa theor = to_extended_halfway(b); where I think we don't really need it but I don't understand the point of jumping through the floating point format, it encodes am_b into an integer, memcpys it to float/double (in to_float), then immediately memcpys it back to an integer (in to_extended called from to_extended_halfway) and then unpacks it with some adjustments.
next reply other threads:[~2022-10-31 11:23 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-31 11:23 jakub at gcc dot gnu.org [this message] 2022-11-01 13:57 ` [Bug libstdc++/107468] " ppalka at gcc dot gnu.org 2022-11-01 20:17 ` ppalka at gcc dot gnu.org 2022-11-07 14:17 ` cvs-commit at gcc dot gnu.org 2022-11-07 14:20 ` jakub at gcc dot gnu.org 2022-11-07 16:53 ` redi at gcc dot gnu.org 2022-11-24 9:39 ` cvs-commit at gcc dot gnu.org 2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107468-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).