From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8661D3853822; Mon, 31 Oct 2022 15:25:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8661D3853822
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1667229955;
	bh=zxnF1JV+qaEJwQDZng4dXaC+5Fl8ieBtlLpSrKGmWAU=;
	h=From:To:Subject:Date:From;
	b=uiLOnGOV9vvS3XKQji2JEUvb9wYUcOMw9F9qJAkB+w/5a6BKkCWUxERc6ZVORrHHv
	 V8e8yCSBQK4Q7/X1uJU4oKAWna7W00+F5pZL9uKlIVz+j6WYjcxpUG9ubWCqtiIeom
	 YNLCQvkmpxC4Q2jdeHDUBe1H0Vk4uwqqQ2fxmVio=
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/107475] New: [10/11/12/13 Regression] libgnat fails to link
 libgnat.so on systems with older glibc on x86_64-linux-gnux32
Date: Mon, 31 Oct 2022 15:25:41 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-107475-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107475

            Bug ID: 107475
           Summary: [10/11/12/13 Regression] libgnat fails to link
                    libgnat.so on systems with older glibc on
                    x86_64-linux-gnux32
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
  Target Milestone: ---

This was introduced with the fix and backports of PR103530 on
x86_64-linux-gnux32 with older glibc versions (checked with 2.31), where dl=
addr
is still in the libdl.so library, and not included in libc.so as in newer g=
libc
versions.


[...]
/usr/x86_64-linux-gnux32/bin/ld: s-trasym.o: in function
`system__traceback__symbolic__module_na
me__getXnn':
collect2: error: ld returned 1 exit status
make[8]: *** [gcc-interface/Makefile:677: gnatlib-shared-default] Error 1

https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dpatch;h=3D9d6c63ba490ec92245f04b5c=
bafc56abd28e8d22

-- a/gcc/ada/Makefile.rtl
+++ b/gcc/ada/Makefile.rtl
@@ -2650,13 +2650,18 @@ ifeq ($(strip $(filter-out %x32 linux%,$(target_cpu)
$(target_os))),)
   s-tasinf.adb<libgnarl/s-tasinf__linux.adb \
   s-tpopsp.adb<libgnarl/s-tpopsp__tls.adb \
   s-taspri.ads<libgnarl/s-taspri__posix.ads \
+  $(TRASYM_DWARF_UNIX_PAIRS) \
+  s-tsmona.adb<libgnat/s-tsmona__linux.adb \
   $(ATOMICS_TARGET_PAIRS) \
   $(X86_64_TARGET_PAIRS) \
+  $(GNATRTL_128BIT_PAIRS) \
   system.ads<libgnat/system-linux-x86.ads

The addition of s-tsmona.adb<libgnat/s-tsmona__linux.adb pulls in the refer=
ence
to dladdr, however not setting MISCLIB to -ldl as on other architectures

Proposed patch:

--- a/gcc/ada/Makefile.rtl
+++ b/gcc/ada/Makefile.rtl
@@ -2584,6 +2584,7 @@ ifeq ($(strip $(filter-out %x32 linux%,$(target_cpu)
$(target_os))),)
   EXTRA_GNATRTL_TASKING_OBJS=3Ds-linux.o a-exetim.o
   EH_MECHANISM=3D-gcc
   THREADSLIB=3D-lpthread -lrt
+  MISCLIB =3D -ldl
   GNATLIB_SHARED=3Dgnatlib-shared-dual
   GMEM_LIB =3D gmemlib
   LIBRARY_VERSION :=3D $(LIB_VERSION)=