public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107493] [13 Regression] Wrong code at -Os on x86_64-linux-gnu
Date: Tue, 08 Nov 2022 13:29:02 +0000	[thread overview]
Message-ID: <bug-107493-4-yA7wb4t5Kk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107493-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107493

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
a_lsm.9_12 = PHI <-21(2), _4(3)>

(set_scalar_evolution
  instantiated_below = 2
  (scalar = a_lsm.9_12)
  (scalar_evolution = (int) {65515, +, 10}_1))

is definitely wrong since the initial value is off.  The evolution after
that looks OK though, so not sure why SCCP gets the wrong final value here,
we compute the number of iterations to zero (also wrong).

It goes wrong when we get to the truncation, we then do

        *evolution_of_loop = chrec_convert (type, *evolution_of_loop, at_stmt);

with {-21, + 2}_1 converting that to unsigned short.  This ends up in
convert_affine_scev but that assumes it converts the cycle and not that
the conversion is inside the cycle.

The old sanity checking of the initial value would have catched this but the
actual error is elsewhere.  The question is what's valid here.  I'm going to
try restricting this all further.

  parent reply	other threads:[~2022-11-08 13:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 11:49 [Bug c/107493] New: " shaohua.li at inf dot ethz.ch
2022-11-01 15:25 ` [Bug tree-optimization/107493] [13 Regression] " pinskia at gcc dot gnu.org
2022-11-01 15:27 ` pinskia at gcc dot gnu.org
2022-11-05 10:37 ` rguenth at gcc dot gnu.org
2022-11-08 13:29 ` rguenth at gcc dot gnu.org [this message]
2022-11-21 12:17 ` [Bug tree-optimization/107493] [13 Regression] Wrong code at -Os on x86_64-linux-gnu since r13-3486-g4c5b116077638277 marxin at gcc dot gnu.org
2022-11-22  8:09 ` rguenth at gcc dot gnu.org
2022-11-28 10:17 ` cvs-commit at gcc dot gnu.org
2022-11-28 10:18 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107493-4-yA7wb4t5Kk@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).