From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6A0EB3857366; Wed, 2 Nov 2022 18:49:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A0EB3857366 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667414966; bh=+MZSMk0zinY15A12IoqpSvrfBt38ITrcL8R5aPRJzXI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JrfhXFv/M6caP5ZNW17V5fAWzUXcqKGWsHxW+0D5XAQAZNRSyidsuxuBNtOrlu8X8 WzQ2XZlPCzZRvnwmjWlTQQFurw2+FOw6nyqC/uAzmdm5en0vKh1XvkN1qzHhzcMquW wUYSlW/ffBQDFYnoAhhSmgnCiSengLybuuIlVq0s= From: "amonakov at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/107505] [13 Regression] ICE: verify_flow_info failed (error: returns_twice call is not first in basic block 2) Date: Wed, 02 Nov 2022 18:49:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: ice-checking, ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: amonakov at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107505 Alexander Monakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amonakov at gcc dot gnu.org --- Comment #1 from Alexander Monakov --- Thanks. This is tree-ssa-sink relocating the call after 'zero' is discovere= d to be const, so I think the fix may be as simple as diff --git a/gcc/tree-ssa-sink.cc b/gcc/tree-ssa-sink.cc index 921305201..631fc88c3 100644 --- a/gcc/tree-ssa-sink.cc +++ b/gcc/tree-ssa-sink.cc @@ -266,11 +266,11 @@ statement_sink_location (gimple *stmt, basic_block frombb, /* We only can sink assignments and non-looping const/pure calls. */ int cf; if (!is_gimple_assign (stmt) && (!is_gimple_call (stmt) || !((cf =3D gimple_call_flags (stmt)) & (ECF_CONST|ECF_PURE)) - || (cf & ECF_LOOPING_CONST_OR_PURE))) + || (cf & (ECF_LOOPING_CONST_OR_PURE|ECF_RETURNS_TWICE)))) return false; /* We only can sink stmts with a single definition. */ def_p =3D single_ssa_def_operand (stmt, SSA_OP_ALL_DEFS); if (def_p =3D=3D NULL_DEF_OPERAND_P)=