From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 047CF3857C77; Thu, 3 Nov 2022 13:48:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 047CF3857C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667483286; bh=3733yQGWZJ0FGe/PqySupE7kxy18LfbeZ2VufLaQPU0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qlG0N4S8oSuo13NQcXpVNL9JeKZJaWGzvnhkLKR4xWX89Ot6KDLcniwdzcmrI/EFH TgMIGfNrF5NbjR07fpPoLWEm7TWdcRmrQ5P+hL3btZbSNJj3gU7QaF8nbVIQ6Cf7aH P9/r4B/otitkIoOaarAs9/BZ5GiAYrriVJE5TB9c= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: =?UTF-8?B?W0J1ZyBtaWRkbGUtZW5kLzEwNzUxN10gW09wZW5NUF1bNS4wXSAn?= =?UTF-8?B?dGFyZ2V0IHVwZGF0ZScgd2l0aCBzdHJpZGVzIOKAlCBmb3IgQy9DKysgYW5k?= =?UTF-8?B?IEZvcnRyYW4=?= Date: Thu, 03 Nov 2022 13:48:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: openmp, rejects-valid X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107517 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #1 from Jakub Jelinek --- OpenMP 4.5 had: "If a list item is an array section it must specify contiguous storage." restriction on target update, which got dropped in 5.0. For the implementation, I think we have multiple possibilities. One is to do what we'll need to do e.g. for map clause with iterators (that= is 5.1 feature which we still don't implement), so basically arrange for havin= g a VLA for GOMP_target* arrays and fill them with runtime loops. Or add some new GOMP_MAP_* to represent record that will describe some stri= ded mapping or to/from update, perhaps pointing to arguments like omp_target_memcpy_rect has to describe, and let the library handle it. Or a mixture thereof. If it is easily describable, advantage of handling it on the library side w= ould be that we could use some smarter host to device or vice versa copying if a plugin supports them (I think Cuda has some support but I think we don't us= e it even for omp_target_memcpy_rect).=