public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107525] propagate_const should not be using SFINAE on its conversion operators
Date: Fri, 04 Nov 2022 14:26:28 +0000	[thread overview]
Message-ID: <bug-107525-4-8Zkf95bpmk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107525-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107525

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
And the spec seems wrong as well. The const overload should be constrained for
const T being convertible to const element_type*.

This should probably not compile:

#include <experimental/propagate_const>

struct X
{
  int& operator*() { return *i; }
  const int& operator*() const { return *i; }
  int* get() { return i; }
  const int* get() const { return i; }
  int* i = nullptr;

  operator int*() { return i; }
  operator const int*() const = delete;
};

int main()
{
  using std::experimental::propagate_const;

  X x;
  const propagate_const<X> px(x);

  static_assert(!std::is_convertible_v<const X, const int*>);
  static_assert(std::is_convertible_v<const propagate_const<X>, const int*>);
  const int* pi = px;
}

  parent reply	other threads:[~2022-11-04 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 11:38 [Bug libstdc++/107525] New: " dangelog at gmail dot com
2022-11-04 13:59 ` [Bug libstdc++/107525] " redi at gcc dot gnu.org
2022-11-04 14:07 ` redi at gcc dot gnu.org
2022-11-04 14:26 ` redi at gcc dot gnu.org [this message]
2022-11-04 14:43 ` dangelog at gmail dot com
2022-11-04 15:04 ` redi at gcc dot gnu.org
2022-11-04 15:09 ` redi at gcc dot gnu.org
2022-11-04 15:10 ` redi at gcc dot gnu.org
2022-11-04 15:15 ` ville.voutilainen at gmail dot com
2022-11-04 15:58 ` dangelog at gmail dot com
2022-11-05 14:01 ` cvs-commit at gcc dot gnu.org
2022-11-05 14:04 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107525-4-8Zkf95bpmk@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).