public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/107533] Inefficient code sequence for fp16 testcase on aarch64 Date: Fri, 19 May 2023 04:12:55 +0000 [thread overview] Message-ID: <bug-107533-4-rPkDuRjyOP@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107533-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107533 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Last reconfirmed| |2023-05-19 Ever confirmed|0 |1 Severity|normal |enhancement Status|UNCONFIRMED |NEW --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Take: ``` struct phalf { __fp16 first; __fp16 second; }; void phalf_copy_(struct phalf *d, struct phalf src) { *d = src; } struct phalf phalf_copy0( __fp16 f, __fp16 s) { struct phalf t = {f, s}; return t; } struct phalf phalf_copy(struct phalf* src) { return *src; } struct phalf phalf_copy1(__fp16 *f, __fp16 *s) { struct phalf t = {*f, *s}; return t; } void phalf_copy2(struct phalf *d, __fp16 *f, __fp16 *s) { struct phalf t = {*f, *s}; *d = t; } void phalf_copy3(struct phalf *d, struct phalf* src) { *d = *src; } void phalf_copy4(struct phalf *d, __fp16 f, __fp16 s) { struct phalf t = {f, s}; *d = t; } ``` 2,3,4 are all ok, while 0, none, _ and 1 are bad. Which points to return values and argument passing being bad (which we already knew had issues). Confirmed.
prev parent reply other threads:[~2023-05-19 4:12 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-05 7:42 [Bug target/107533] New: " ramana at gcc dot gnu.org 2023-05-19 4:12 ` pinskia at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107533-4-rPkDuRjyOP@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).