From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 3344D3858417; Mon,  7 Nov 2022 23:36:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3344D3858417
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1667864192;
	bh=k63lYCli2GO+MsmoIMBCwuhuVdDYfB9gUu/brDwRpuw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=kz7OUDFUoxYGU/l7OEDXHbUYFCiY0mmUpWehOe6cPJU4Z7gqU7reNpfLLAVY5RrNt
	 vyPLgIEFDWY62iFNbKWWxqGx5w/7tM0PbDIUBsUytdFNZNdIe+QXlC/LZJNZYvoRcc
	 QqJZcnKBo8jLyKIruSYX4F9e+FpVKQKPY2rKiphk=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29
 breaks build on powerpc64 BE
Date: Mon, 07 Nov 2022 23:36:31 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107562-4-WL4SOak5m4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107562-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107562-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107562

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b457b779427b0f7b3fbac447811c9c52db5bc79e

commit r13-3763-gb457b779427b0f7b3fbac447811c9c52db5bc79e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Nov 8 00:35:09 2022 +0100

    libstdc++: Fix up libstdc++ build against glibc 2.25 or older [PR107562]

    On Mon, Nov 07, 2022 at 05:48:42PM +0000, Jonathan Wakely wrote:
    > On Mon, 7 Nov 2022 at 16:11, Joseph Myers <joseph@codesourcery.com>
wrote:
    > >
    > > On Wed, 2 Nov 2022, Jakub Jelinek via Gcc-patches wrote:
    > >
    > > > APIs.  So that one can build gcc against older glibc and then com=
pile
    > > > user programs on newer glibc, the patch uses weak references unle=
ss
    > > > gcc is compiled against glibc 2.26+.  strfromf128 unfortunately c=
an't
    > >
    > > This support for older glibc doesn't actually seem to be working, o=
n an
    > > older system with glibc 2.19 I'm seeing
    > >
    > >
/scratch/jmyers/fsf/gcc-mainline/libstdc++-v3/src/c++17/floating_to_chars.c=
c:52:3:
error: expected initializer before '__asm'
    > >    52 |   __asm ("strfromf128");
    > >       |   ^~~~~
    > >
    > > and a series of subsequent errors.
    >
    > This seems to "fix" it (not sure if it's right though):
    >
    > #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
    > extern "C" _Float128 __strtof128(const char*, char**)
    >  __attribute__((__weak__));
    > #endif
    > extern "C" _Float128 __strtof128(const char*, char**)
    >  __asm ("strtof128");

    It is, but floating_from_chars.cc has the same problem,
    and I think we can avoid the duplication, like this:

    2022-11-08  Jakub Jelinek  <jakub@redhat.com>

            PR libstdc++/107562
            * src/c++17/floating_from_chars.cc (__strtof128): Put __asm bef=
ore
            __attribute__.
            * src/c++17/floating_to_chars.cc (__strfromf128): Likewise.=