public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107591] range-op{,-float}.cc for x * x
Date: Wed, 09 Nov 2022 18:35:58 +0000	[thread overview]
Message-ID: <bug-107591-4-gwteMP2KB6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107591-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107591

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #11)
> no, I meant in addition to the VREL_EQ.  so 
>   if (rel == VREL_EQ && op1_range != op2_range)
>      then you know you have something like  if (x == y) z=x*y and may have
> to check for various signed zero cobinations in each range, 
> whereas is op1_range == op2_range in this case, it should be perfectly safe..

I don't understand.  Let's modify the testcase to:
float
foo (float x, y)
{
  if (x < -13.f || x > 26.f)
    return -1.0f;
  if (y < -13.f || y > 26.f)
    return -1.0f;
  if (x == y)
    return x * y;
  return 42.0f;
}
I'd expect that fold_range on the x * y should see trio.op1_op2 () == VREL_EQ
because of the guarding x == y condition.  And the ranges of both are [-13.f,
26.f] +-NAN too.  Still, x could be -0.0f and y 0.0f or vice versa, and so
x * y could be -0.0f, so we need [-0.f, 676.f] +-NAN.  While if it is x * x, we
know the result will have always sign bit of 0 (except if NAN), so [0.f, 676.f]
+-NAN.

  parent reply	other threads:[~2022-11-09 18:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 15:37 [Bug tree-optimization/107591] New: " jakub at gcc dot gnu.org
2022-11-09 15:49 ` [Bug tree-optimization/107591] " aldyh at gcc dot gnu.org
2022-11-09 15:55 ` aldyh at gcc dot gnu.org
2022-11-09 15:57 ` jakub at gcc dot gnu.org
2022-11-09 15:59 ` pinskia at gcc dot gnu.org
2022-11-09 16:01 ` pinskia at gcc dot gnu.org
2022-11-09 16:02 ` aldyh at gcc dot gnu.org
2022-11-09 16:04 ` aldyh at gcc dot gnu.org
2022-11-09 16:31 ` jakub at gcc dot gnu.org
2022-11-09 16:40 ` jakub at gcc dot gnu.org
2022-11-09 17:45 ` amacleod at redhat dot com
2022-11-09 17:49 ` jakub at gcc dot gnu.org
2022-11-09 18:22 ` amacleod at redhat dot com
2022-11-09 18:35 ` jakub at gcc dot gnu.org [this message]
2022-11-09 19:20 ` amacleod at redhat dot com
2022-11-09 20:24 ` jakub at gcc dot gnu.org
2022-11-09 20:45 ` jakub at gcc dot gnu.org
2022-11-09 22:25 ` amacleod at redhat dot com
2022-11-09 23:27 ` jakub at gcc dot gnu.org
2022-11-12  8:42 ` cvs-commit at gcc dot gnu.org
2023-04-05  7:14 ` pilarlatiesa at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107591-4-gwteMP2KB6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).