[Bug c++/107616] New: c++tools: select not found breaks build

[Bug c++/107616] New: c++tools: select not found breaks build

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107616

            Bug ID: 107616
           Summary: c++tools: select not found breaks build
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa64-hp-hpux11.11
            Target: hppa64-hp-hpux11.11
             Build: hppa64-hp-hpux11.11

On hpux11.[0-2]*, the select declaration reside in <sys/time.h>.  configure
only checks <sys/select.h>.  As a result, select is not found:

configure:3623: checking for select
configure:3642:  /home/dave/gnu/gcc/objdir64/./gcc/xg++
-B/home/dave/gnu/gcc/objdir64/./gcc/ -nostdinc++ -nostdinc++
-I/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/include/hppa64-hp-hpux11.11
-I/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/include
-I/home/dave/gnu/gcc/gcc/libstdc++-v3/libsupc++
-I/home/dave/gnu/gcc/gcc/libstdc++-v3/include/backward
-I/home/dave/gnu/gcc/gcc/libstdc++-v3/testsuite/util
-L/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/src
-L/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/src/.libs
-L/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/libsupc++/.libs
-B/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/src/.libs
-B/home/dave/gnu/gcc/objdir64/hppa64-hp-hpux11.11/libstdc++-v3/libsupc++/.libs
-B/opt/gnu64/gcc/gcc-13/hppa64-hp-hpux11.11/bin/
-B/opt/gnu64/gcc/gcc-13/hppa64-hp-hpux11.11/lib/ -isystem
/opt/gnu64/gcc/gcc-13/hppa64-hp-hpux11.11/include -isystem
/opt/gnu64/gcc/gcc-13/hppa64-hp-hpux11.11/sys-include   -fchecking=1 -c -g -O2 
  conftest.cpp >&5
conftest.cpp:24:10: fatal error: sys/select.h: No such file or directory
   24 | #include <sys/select.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
...
configure:3649: result: no

This exposes a problem in server.cc.  The call to FD_ISSET at line 724
is not conditional on "#if defined (HAVE_PSELECT) || defined (HAVE_SELECT)".

[Bug c++/107616] c++tools: select not found breaks build

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107616

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
Created attachment 53870
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53870&action=edit
Patch

Fix build of server.cc when select is not present.

[Bug c++/107616] c++tools: select not found breaks build

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107616

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Patch:
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609536.html

[Bug c++/107616] c++tools: select not found breaks build

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107616

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by John David Anglin <danglin@gcc.gnu.org>:

https://gcc.gnu.org/g:0925a9772960c946440833033423bff41c330154

commit r13-5072-g0925a9772960c946440833033423bff41c330154
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Mon Jan 9 15:41:51 2023 +0000

    Fix compilation of server.cc on hpux.

    Select and FD_ISSET are declared in sys/time.h on most versions
    of hpux.  As a result, HAVE_PSELECT and HAVE_SELECT can be 0.

    2023-01-08  John David Anglin  <danglin@gcc.gnu.org>

    c++tools/ChangeLog:

            PR other/107616
            * server.cc (server): Don't call FD_ISSET when HAVE_PSELECT
            and HAVE_SELECT are zero.

[Bug c++/107616] c++tools: select not found breaks build

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107616

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed on trunk.