public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107649] New std::complex specializations are never used
Date: Wed, 16 Nov 2022 13:47:02 +0000	[thread overview]
Message-ID: <bug-107649-4-YgH1GTYpoD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107649-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107649

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0e2c5510e001e5ccbde9e4b7df757e2bba2fdb00

commit r13-4096-g0e2c5510e001e5ccbde9e4b7df757e2bba2fdb00
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Nov 16 14:45:40 2022 +0100

    libstdc++: Fix up <complex> for extended floating point types [PR107649]

    As filed by Jonathan in the PR, I've screwed up the requires syntax
    in the extended floating point specialization:
    -    requires(__complex_type<_Tp>::type)
    +    requires requires { typename __complex_type<_Tp>::type; }
    and doing this change resulted in lots of errors because __complex_whatever
    overfloads from extended floating point types were declared after the
    templates which used them.

    The following patch fixes that.

    Bootstrapped/regtested on x86_64-linux and i686-linux, additionally
    I've tested that with _GLIBCXX_HAVE_FLOAT128_MATH not being defined
    while __STDCPP_FLOAT128_T__ defined one can still use
    std::complex<std::float128_t> for basic arithmetic etc., just one can't
    expect std::sin etc. to work in that case (because we don't have any
    implementation).

    2022-11-16  Jakub Jelinek  <jakub@redhat.com>
                Jonathan Wakely  <jwakely@redhat.com>

            PR libstdc++/107649
            * include/std/complex (__complex_abs, __complex_arg, __complex_cos,
            __complex_cosh, __complex_exp, __complex_log, __complex_sin,
            __complex_sinh, __complex_sqrt, __complex_tan, __complex_tanh,
            __complex_pow): Move __complex__ _Float{16,32,64,128} and
            __complex__ decltype(0.0bf16) overloads earlier in the file.
            (complex): Fix up requires on the partial specialization for
extended
            float types.
            (__complex_acos, __complex_asin, __complex_atan, __complex_acosh,
            __complex_asinh, __complex_atanh): Move
            __complex__ _Float{16,32,64,128} and __complex__ decltype(0.0bf16)
            overloads earlier in the file.

  parent reply	other threads:[~2022-11-16 13:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 20:46 [Bug libstdc++/107649] New: " redi at gcc dot gnu.org
2022-11-11 20:49 ` [Bug libstdc++/107649] " redi at gcc dot gnu.org
2022-11-11 20:52 ` redi at gcc dot gnu.org
2022-11-12  8:29 ` jakub at gcc dot gnu.org
2022-11-12 12:34 ` redi at gcc dot gnu.org
2022-11-16 13:47 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-17  0:36 ` redi at gcc dot gnu.org
2022-11-19 15:08 ` cvs-commit at gcc dot gnu.org
2022-11-28 22:32 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107649-4-YgH1GTYpoD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).