public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/107688] [C++23] P2615 - Meaningful exports
Date: Wed, 01 May 2024 05:05:04 +0000	[thread overview]
Message-ID: <bug-107688-4-XRb4yWz883@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107688-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107688

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:79420dd344145819677b3f975bb305a778fcaf91

commit r15-84-g79420dd344145819677b3f975bb305a778fcaf91
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Mon Mar 4 23:58:30 2024 +1100

    c++: Implement P2615 'Meaningful Exports' [PR107688]

    This clarifies which kinds of declarations may and may not be exported
    in various contexts. The patch additionally fixes up some small issues
    that were clarified by the paper.

    Most of the changes are with regards to export-declarations, which are
    applied for all standards modes that we support '-fmodules-ts' for.
    However there are also a couple of changes made to linkage specifiers
    ('extern "C"'); I've applied these as since C++20, to line up with when
    modules were actually introduced.

            PR c++/107688

    gcc/cp/ChangeLog:

            * name-lookup.cc (push_namespace): Error when exporting
            namespace with internal linkage.
            * parser.h (struct cp_parser): Add new flag
            'in_unbraced_export_declaration_p'.
            * parser.cc (cp_debug_parser): Print the new flag.
            (cp_parser_new): Initialise the new flag.
            (cp_parser_module_export): Set the new flag.
            (cp_parser_class_specifier): Clear and restore the new flag.
            (cp_parser_import_declaration): Imports can now appear directly
            in a linkage specification.
            (cp_parser_declaration): Categorise declarations as "name" or
            "special"; error on the later in contexts where the former is
            required.
            (cp_parser_class_head): Error when exporting a partial
            specialisation.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/contracts-1_a.C: Avoid now-illegal syntax.
            * g++.dg/modules/contracts-2_a.C: Likewise.
            * g++.dg/modules/contracts-3_a.C: Likewise.
            * g++.dg/modules/contracts-4_a.C: Likewise.
            * g++.dg/modules/lang-1_c.C: Clarify now-legal syntax.
            * g++.dg/modules/pr101582-1.C: Remove now-legal XFAILS.
            * g++.dg/template/crash71.C: Update error messages.
            * g++.dg/cpp2a/linkage-spec1.C: New test.
            * g++.dg/modules/export-3.C: New test.
            * g++.dg/modules/export-4_a.C: New test.
            * g++.dg/modules/export-4_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

  parent reply	other threads:[~2024-05-01  5:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 18:42 [Bug c++/107688] New: " mpolacek at gcc dot gnu.org
2022-11-14 18:42 ` [Bug c++/107688] " mpolacek at gcc dot gnu.org
2024-03-04 14:22 ` nshead at gcc dot gnu.org
2024-05-01  5:05 ` cvs-commit at gcc dot gnu.org [this message]
2024-05-01  5:06 ` nshead at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107688-4-XRb4yWz883@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).