public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug preprocessor/107691] New: libcpp configure fails on bashism
@ 2022-11-14 20:17 rep.dot.nop at gmail dot com
2022-11-14 20:22 ` [Bug preprocessor/107691] [10/11/12/13 Regression] " pinskia at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: rep.dot.nop at gmail dot com @ 2022-11-14 20:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
Bug ID: 107691
Summary: libcpp configure fails on bashism
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: preprocessor
Assignee: unassigned at gcc dot gnu.org
Reporter: rep.dot.nop at gmail dot com
Target Milestone: ---
New debian install, /bin/sh points to dash
/scratch/src/gcc-13.orig/libcpp/configure: line 7847: test: =: unary operator
expected
line 7847 reads
if (test $have_valgrind_h = no \
Why those superfluous braces? Removing them fixes the shell script.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on bashism
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
@ 2022-11-14 20:22 ` pinskia at gcc dot gnu.org
2022-11-14 20:45 ` [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion schwab@linux-m68k.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-14 20:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Known to fail| |7.1.0
Known to work|7.0 |6.1.0
Summary|libcpp configure fails on |[10/11/12/13 Regression]
|bashism |libcpp configure fails on
| |bashism
Ever confirmed|0 |1
Target Milestone|--- |10.5
Keywords| |build
Last reconfirmed| |2022-11-14
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
GCC 7 had the patch.
r7-912-gceb17928e5d1d5 introduced the bad code into configure.ac.
Confirmed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
2022-11-14 20:22 ` [Bug preprocessor/107691] [10/11/12/13 Regression] " pinskia at gcc dot gnu.org
@ 2022-11-14 20:45 ` schwab@linux-m68k.org
2022-11-14 20:56 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: schwab@linux-m68k.org @ 2022-11-14 20:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
Andreas Schwab <schwab@linux-m68k.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[10/11/12/13 Regression] |[10/11/12/13 Regression]
|libcpp configure fails on |libcpp configure fails on
|bashism |empty expansion
--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> ---
That's 100% POSIX conforming, it's just $have_valgrind_h etc. expanding to
nothing (only gcc/configure has the necessary checks).
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
2022-11-14 20:22 ` [Bug preprocessor/107691] [10/11/12/13 Regression] " pinskia at gcc dot gnu.org
2022-11-14 20:45 ` [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion schwab@linux-m68k.org
@ 2022-11-14 20:56 ` pinskia at gcc dot gnu.org
2022-11-14 21:02 ` rep.dot.nop at gmail dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-14 20:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
have_valgrind_h is never set anywhere.
Adding before that code in configure.ac:
dnl # This check AC_REQUIREs various stuff, so it *must not* be inside
dnl # an if statement. This was the source of very frustrating bugs
dnl # in converting to autoconf 2.5x!
AC_CHECK_HEADER(valgrind.h, have_valgrind_h=yes, have_valgrind_h=no)
Should fix the issue I think.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
` (2 preceding siblings ...)
2022-11-14 20:56 ` pinskia at gcc dot gnu.org
@ 2022-11-14 21:02 ` rep.dot.nop at gmail dot com
2022-11-19 11:20 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rep.dot.nop at gmail dot com @ 2022-11-14 21:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
--- Comment #4 from rep.dot.nop at gmail dot com <rep.dot.nop at gmail dot com> ---
The problem was encountered with configure --enable-valgrind-annotations with
valgrind not installed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
` (3 preceding siblings ...)
2022-11-14 21:02 ` rep.dot.nop at gmail dot com
@ 2022-11-19 11:20 ` cvs-commit at gcc dot gnu.org
2022-11-22 11:40 ` [Bug preprocessor/107691] [10/11/12 " jakub at gcc dot gnu.org
2023-07-07 10:44 ` [Bug preprocessor/107691] [11/12 " rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-11-19 11:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Bernhard Reutner-Fischer
<aldot@gcc.gnu.org>:
https://gcc.gnu.org/g:5a6c698ea31f587151a2fa4a982c8cc43bd9cc45
commit r13-4165-g5a6c698ea31f587151a2fa4a982c8cc43bd9cc45
Author: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Date: Thu Nov 17 21:40:53 2022 +0100
libcpp: Add missing config for --enable-valgrind-annotations [PR107691]
r7-912 copied (parts of) the valgrind annotation checks from gcc
to libcpp. The above copies the missing pieces to libcpp to diagnose
when libcpp is configured with --enable-valgrind-annotations but
valgrind is not installed.
libcpp/ChangeLog:
PR preprocessor/107691
* configure.ac: Add valgrind header checks.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [10/11/12 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
` (4 preceding siblings ...)
2022-11-19 11:20 ` cvs-commit at gcc dot gnu.org
@ 2022-11-22 11:40 ` jakub at gcc dot gnu.org
2023-07-07 10:44 ` [Bug preprocessor/107691] [11/12 " rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-11-22 11:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[10/11/12/13 Regression] |[10/11/12 Regression]
|libcpp configure fails on |libcpp configure fails on
|empty expansion |empty expansion
CC| |jakub at gcc dot gnu.org
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug preprocessor/107691] [11/12 Regression] libcpp configure fails on empty expansion
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
` (5 preceding siblings ...)
2022-11-22 11:40 ` [Bug preprocessor/107691] [10/11/12 " jakub at gcc dot gnu.org
@ 2023-07-07 10:44 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-07 10:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107691
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.5 |11.5
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-07-07 10:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 20:17 [Bug preprocessor/107691] New: libcpp configure fails on bashism rep.dot.nop at gmail dot com
2022-11-14 20:22 ` [Bug preprocessor/107691] [10/11/12/13 Regression] " pinskia at gcc dot gnu.org
2022-11-14 20:45 ` [Bug preprocessor/107691] [10/11/12/13 Regression] libcpp configure fails on empty expansion schwab@linux-m68k.org
2022-11-14 20:56 ` pinskia at gcc dot gnu.org
2022-11-14 21:02 ` rep.dot.nop at gmail dot com
2022-11-19 11:20 ` cvs-commit at gcc dot gnu.org
2022-11-22 11:40 ` [Bug preprocessor/107691] [10/11/12 " jakub at gcc dot gnu.org
2023-07-07 10:44 ` [Bug preprocessor/107691] [11/12 " rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).