public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284
Date: Tue, 15 Nov 2022 18:52:03 +0000	[thread overview]
Message-ID: <bug-107707-4-CK43pae2vR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107707-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |kargl at gcc dot gnu.org
   Last reconfirmed|                            |2022-11-15
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from kargl at gcc dot gnu.org ---
Another example of why -fmax-errors=1 should be the default.

A run-on warning triggers tried to get a gmp value from a BT_REAL entity.

Fixed by

diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc
index d3e199535b3..ce68d863fdf 100644
--- a/gcc/fortran/interface.cc
+++ b/gcc/fortran/interface.cc
@@ -3271,10 +3271,14 @@ gfc_compare_actual_formal (gfc_actual_arglist **ap,
gfc_formal_arglist *formal,
         and assumed-shape dummies, the string length needs to match
         exactly.  */
       if (a->expr->ts.type == BT_CHARACTER
-         && a->expr->ts.u.cl && a->expr->ts.u.cl->length
+         && a->expr->ts.u.cl
+         && a->expr->ts.u.cl->length
+         && a->expr->ts.u.cl->length->ts.type == BT_INTEGER
          && a->expr->ts.u.cl->length->expr_type == EXPR_CONSTANT
-         && f->sym->ts.type == BT_CHARACTER && f->sym->ts.u.cl
+         && f->sym->ts.type == BT_CHARACTER
+         && f->sym->ts.u.cl
          && f->sym->ts.u.cl->length
+         && f->sym->ts.u.cl->length->ts.type == BT_INTEGER
          && f->sym->ts.u.cl->length->expr_type == EXPR_CONSTANT
          && (f->sym->attr.pointer || f->sym->attr.allocatable
              || (f->sym->as && f->sym->as->type == AS_ASSUMED_SHAPE))

  reply	other threads:[~2022-11-15 18:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 18:03 [Bug fortran/107707] New: " gscfq@t-online.de
2022-11-15 18:52 ` kargl at gcc dot gnu.org [this message]
2022-11-16 21:16 ` [Bug fortran/107707] " anlauf at gcc dot gnu.org
2022-11-16 21:27 ` sgk at troutmask dot apl.washington.edu
2022-11-16 21:51 ` cvs-commit at gcc dot gnu.org
2022-11-16 22:03 ` kargl at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107707-4-CK43pae2vR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).