public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107767] [13 Regression] switch to table conversion happening even though using btq is better
Date: Fri, 02 Dec 2022 15:31:07 +0000	[thread overview]
Message-ID: <bug-107767-4-FI93FtnCvl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107767-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107767

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #7)
> However, the CFG is not collapsed and thus it fails due to:
> 
> bool
> bit_test_cluster::is_beneficial (unsigned count, unsigned uniq)
> {
>   return (((uniq == 1 && count >= 3)
> 	   || (uniq == 2 && count >= 5)
> 	   || (uniq == 3 && count >= 6)));
> }
> 
> as count == 7. and so tree-switch-conversion happens. So one can mitigate
> that with:
> 1) use switch statement instead of if series
> 2) reduce -param=switch-conversion-max-branch-ratio= that will not create so
> big CSWTCH array
> 3) disable tree-switch-conversion pass

But that just means that either iftoswitch should happen earlier or switchconv
later
so that some other pass would remove the redundancies, or iftoswitch should
perform them when it optimizes something, or switchconv should not rely on the
collapsing being done already and do it itself.
In the #c9 testcase, it is cleanup_tree_cfg (TODO_update_ssa) during ccp1 pass
that optimizes it.  But cleanup_tree_cfg (0) during iftoswitch for firewall2
doesn't do that for some reason.

  parent reply	other threads:[~2022-12-02 15:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 13:00 [Bug regression/107767] New: GCC has some problems in optimizer of trivial case socketpair at gmail dot com
2022-11-20 13:02 ` [Bug regression/107767] " socketpair at gmail dot com
2022-11-21  8:46 ` marxin at gcc dot gnu.org
2022-11-21 10:33 ` socketpair at gmail dot com
2022-11-21 15:57 ` [Bug tree-optimization/107767] [13 Regression] " pinskia at gcc dot gnu.org
2022-12-02 14:27 ` [Bug tree-optimization/107767] [13 Regression] switch to table conversion happening even though using btq is better marxin at gcc dot gnu.org
2022-12-02 14:54 ` socketpair at gmail dot com
2022-12-02 15:00 ` marxin at gcc dot gnu.org
2022-12-02 15:07 ` marxin at gcc dot gnu.org
2022-12-02 15:15 ` socketpair at gmail dot com
2022-12-02 15:17 ` jakub at gcc dot gnu.org
2022-12-02 15:27 ` rguenth at gcc dot gnu.org
2022-12-02 15:31 ` jakub at gcc dot gnu.org [this message]
2022-12-02 15:44 ` jakub at gcc dot gnu.org
2022-12-05 14:49 ` marxin at gcc dot gnu.org
2022-12-21  9:46 ` rguenth at gcc dot gnu.org
2022-12-23 14:05 ` marxin at gcc dot gnu.org
2023-01-04 14:26 ` jakub at gcc dot gnu.org
2023-01-06 12:36 ` marxin at gcc dot gnu.org
2023-01-09 10:02 ` rguenth at gcc dot gnu.org
2023-01-11 12:14 ` cvs-commit at gcc dot gnu.org
2023-01-11 12:14 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107767-4-FI93FtnCvl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).