public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107819] ICE in gfc_check_argument_var_dependency, at fortran/dependency.cc:978
Date: Fri, 25 Nov 2022 22:06:52 +0000	[thread overview]
Message-ID: <bug-107819-4-OYyrQbN7Fv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107819-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107819

--- Comment #10 from anlauf at gcc dot gnu.org ---
Created attachment 53968
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53968&action=edit
Revised patch

(In reply to Mikael Morin from comment #9)
> It seems the semantics when an argument has the value attribute is the same
> as the case ELEM_CHECK_VARIABLE in my previous comment.
> So forcing the value of the elemental argument to ELEM_CHECK_VARIABLE at
> some appropriate place could possibly work.

Many thanks for the explanations!

Looking at the involved code, the most simple solution I came up with is
attached.  It scans over the actual arguments associated with the dummies,
and when we find one with the VALUE attribute, we enforce the dependency
check.  It fixes the testcase and regtests fine.

I was struggling with the actual generated code, which is rather a temporary
for the arguments with INTENT(INOUT/OUT), but that should be functionally
equivalent.

  parent reply	other threads:[~2022-11-25 22:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 17:41 [Bug fortran/107819] New: " gscfq@t-online.de
2022-11-22 17:42 ` [Bug fortran/107819] " gscfq@t-online.de
2022-11-22 19:41 ` anlauf at gcc dot gnu.org
2022-11-22 21:01 ` anlauf at gcc dot gnu.org
2022-11-24 13:12 ` mikael at gcc dot gnu.org
2022-11-24 17:07 ` anlauf at gcc dot gnu.org
2022-11-24 19:07 ` mikael at gcc dot gnu.org
2022-11-24 21:24 ` anlauf at gcc dot gnu.org
2022-11-24 21:40 ` mikael at gcc dot gnu.org
2022-11-24 22:02 ` mikael at gcc dot gnu.org
2022-11-25 22:06 ` anlauf at gcc dot gnu.org [this message]
2022-11-26 20:56 ` anlauf at gcc dot gnu.org
2022-11-26 21:05 ` mikael at gcc dot gnu.org
2022-11-27 20:33 ` anlauf at gcc dot gnu.org
2022-11-28 18:54 ` cvs-commit at gcc dot gnu.org
2022-11-28 21:27 ` anlauf at gcc dot gnu.org
2022-11-28 21:57 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107819-4-OYyrQbN7Fv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).