public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/107828] tree-inlining would generate SSA with incorrect def stmt Date: Fri, 02 Dec 2022 17:39:21 +0000 [thread overview] Message-ID: <bug-107828-4-yp5GW5S0ox@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107828-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107828 --- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> --- I don't see any correctness issue here. It is true that when IPA-SRA needs to create a temporary SSA_NAME for an assignment with VIEW_CONVERT_EXPR (that is the only statement that extra_stmts can contain at the moment), the SSA_NAME then get's re-mapped to another while woe could have just re-use the existing one, it is already created within the new function. We could use the knowledge that extra_stmts is really only this one statement or nothing and avoid the remapping but that would be at the expense of universality and extensibility of the interface between tree-inline.cc and ipa-param-manipulations.cc. Please let me know if I am missing something (and preferably with a test-case that demonstrates the problem).
next prev parent reply other threads:[~2022-12-02 17:39 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-23 1:42 [Bug tree-optimization/107828] New: " fxue at os dot amperecomputing.com 2022-11-23 9:49 ` [Bug tree-optimization/107828] " marxin at gcc dot gnu.org 2022-12-02 17:39 ` jamborm at gcc dot gnu.org [this message] 2022-12-08 9:38 ` marxin at gcc dot gnu.org 2022-12-13 10:04 ` fxue at os dot amperecomputing.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107828-4-yp5GW5S0ox@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).