public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "law at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/107831] Missed optimization: -fclash-stack-protection causes unnecessary code generation for dynamic stack allocations that are clearly less than a page Date: Wed, 23 Nov 2022 17:57:56 +0000 [thread overview] Message-ID: <bug-107831-4-tdE2zuHm8G@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107831-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107831 --- Comment #5 from Jeffrey A. Law <law at gcc dot gnu.org> --- Right. You also have to know the distance from the last probe (possibly an implicit one) to the start of the alloca space before you can contemplate eliding the probes in alloca space. There's a hook we can use, but it was more meant for AArch64 IIRC, but we might be able to use it for this purpose. You also have to worry about dynamic allocations in a loop. A single byte alloca could jump the stack if it's inside loop with a suitable number of iterations. In general, the model taken was to try and minimize explicit probes in the common case (ie, function entry) at the expense of taking additional probes in the uncommon case (dynamic allocations).
next prev parent reply other threads:[~2022-11-23 17:57 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-23 10:09 [Bug c/107831] New: " pskocik at gmail dot com 2022-11-23 12:34 ` [Bug c/107831] " pskocik at gmail dot com 2022-11-23 17:01 ` jakub at gcc dot gnu.org 2022-11-23 17:05 ` jakub at gcc dot gnu.org 2022-11-23 17:37 ` jakub at gcc dot gnu.org 2022-11-23 17:57 ` law at gcc dot gnu.org [this message] 2022-11-23 21:27 ` pskocik at gmail dot com 2022-11-24 19:16 ` pskocik at gmail dot com 2022-11-24 19:31 ` jakub at gcc dot gnu.org 2022-12-17 19:51 ` pskocik at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107831-4-tdE2zuHm8G@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).