From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 63642384EF5C; Fri, 25 Nov 2022 15:07:51 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63642384EF5C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1669388871;
	bh=TzGoIVNpuJqTjrtKVHOsuHeHLUxDcNhGhpp2wNvXCZk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=uU0cvTNADSYWWOHrYEievOMTerAMH/kFu+3E34v3dc3SLpsr0wGIwMbnowAEojuZY
	 5qaCH9ZHUoQwXhdthHk4OaEZqlIkL6QLHrjJvfDsgDmOVJkz5JirTq4aStlscw/Xhx
	 YcmSXywOLOYPBTDHIsNmk21KL+gxoMcFLGLfUI3c=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107850] [12/13 Regression] std::erase_if (map) forces
 predicate to takes a const value_type
Date: Fri, 25 Nov 2022 15:07:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 12.1.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107850-4-gKdgs4BAgL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107850-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107850-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107850

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:f54ceb2062c7fef294f85ae093914fa6c7ca35b8

commit r13-4306-gf54ceb2062c7fef294f85ae093914fa6c7ca35b8
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 24 21:09:03 2022 +0000

    libstdc++: Call predicate with non-const values in std::erase_if [PR107=
850]

    As specified in the standard, the predicate for std::erase_if has to be
    invocable as non-const with a non-const lvalues argument. Restore
    support for predicates that only accept non-const arguments.

    It's not strictly nevessary to change it for the set and unordered_set
    overloads, because they only give const access to the elements anyway.
    I've done it for them too just to keep them all consistent.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107850
            * include/bits/erase_if.h (__erase_nodes_if): Use non-const
            reference to the container.
            * include/experimental/map (erase_if): Likewise.
            * include/experimental/set (erase_if): Likewise.
            * include/experimental/unordered_map (erase_if): Likewise.
            * include/experimental/unordered_set (erase_if): Likewise.
            * include/std/map (erase_if): Likewise.
            * include/std/set (erase_if): Likewise.
            * include/std/unordered_map (erase_if): Likewise.
            * include/std/unordered_set (erase_if): Likewise.
            * testsuite/23_containers/map/erasure.cc: Check with
            const-incorrect predicate.
            * testsuite/23_containers/set/erasure.cc: Likewise.
            * testsuite/23_containers/unordered_map/erasure.cc: Likewise.
            * testsuite/23_containers/unordered_set/erasure.cc: Likewise.
            * testsuite/experimental/map/erasure.cc: Likewise.
            * testsuite/experimental/set/erasure.cc: Likewise.
            * testsuite/experimental/unordered_map/erasure.cc: Likewise.
            * testsuite/experimental/unordered_set/erasure.cc: Likewise.=