From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 40CC3381D446; Sat, 26 Nov 2022 04:57:43 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40CC3381D446
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1669438663;
	bh=q0cJAmgInOMmNQwoFhXGYHcgiOv/JS21pA1/3bxwsWk=;
	h=From:To:Subject:Date:From;
	b=i68YqMet5gFTy1cgEZK6ZQOvAU607AUooNcjIjGtVJEyaVBj1EXL7S3A15nVnJdWy
	 8+u04s6fSquOrSiOTPsMUTAJF3xmq+6lDf6KAKFGtfaXNuGjOcPR1WN5vGPiqUOGK7
	 KynUgapAaAyUodHxcOynJ9DH15EEoPKVGuWazdFs=
From: "john.harper at vuw dot ac.nz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107874] New: merge not using all its arguments
Date: Sat, 26 Nov 2022 04:57:42 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: john.harper at vuw dot ac.nz
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-107874-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107874

            Bug ID: 107874
           Summary: merge not using all its arguments
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: john.harper at vuw dot ac.nz
  Target Milestone: ---

The F2018 standard 15.5.3 requires all actual arguments in a function refer=
ence
to be evaluated.

In the program below, merge has three scalar arguments; ifort evaluates
all three, gfortran evaluates only the useful two, which violates 15.5.3.

program testmerge9
  implicit none
  integer i
  logical:: x(2)=3D(/.true., .false./), y ! avoiding [ ] allows f95 option
  do i =3D 1,2
     y =3D merge(tstuff(),fstuff(),x(i))
     print *,y
  end do
contains
  logical function tstuff()
    print *,'tstuff'
    tstuff =3D .true.
  end function tstuff

  logical function fstuff()
    print *,'fstuff'
    fstuff =3D .false.
  end function fstuff
end program testmerge9

Steve Kargl said "Looks like a bug. Feel free to send a bug report with this
patch."

diff --git a/gcc/fortran/trans-intrinsic.cc b/gcc/fortran/trans-intrinsic.cc
index bb938026828..c5b63d356e1 100644
--- a/gcc/fortran/trans-intrinsic.cc
+++ b/gcc/fortran/trans-intrinsic.cc
@@ -7538,9 +7538,9 @@ gfc_conv_intrinsic_merge (gfc_se * se, gfc_expr * exp=
r)
   gfc_conv_intrinsic_function_args (se, expr, args, num_args);
   if (expr->ts.type !=3D BT_CHARACTER)
     {
-      tsource =3D args[0];
-      fsource =3D args[1];
-      mask =3D args[2];
+      tsource =3D gfc_evaluate_now (args[0], &se->pre);
+      fsource =3D gfc_evaluate_now (args[1], &se->pre);
+      mask =3D gfc_evaluate_now (args[2], &se->pre);
     }
   else
     {=