public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107880] bool tautology missed optimisation
Date: Mon, 28 Aug 2023 22:52:09 +0000	[thread overview]
Message-ID: <bug-107880-4-HtqTH0GkE7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107880-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107880

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
With a patch I have for PR 95185

we get:
```
  _1 = b_2(D) == a_3(D);
  _10 = b_2(D) ^ a_3(D);
  _5 = _1 ^ _10;
```

Which is better than before.

One more improvement would be:
```
bool a(bool x, bool y)
{
        bool t = x == y;
        return t ^ x;
}
```

Into:
```
bool a0(bool x, bool y)
{
        bool t = (x ^ y);
        return t ^ x ^1; // ~y
}
```

So the 2 which are needed still:

/* (a == b) ^ a -> b^1 */
(simplify
 (bit_xor:c (eq:c zero_one_valued_p@0 zero_one_valued_p@1) @0)
 (bit_xor @1 { build_one_cst (type); })

/* (a == b) ^ (a^b) -> b^(b^1) or (b^b)^1 or rather 1 */
(simplify
 (bit_xor:c (eq:c zero_one_valued_p@0 zero_one_valued_p@1) (bit_xor:c @0 @1))
 { build_one_cst (type); })

So mine.

  parent reply	other threads:[~2023-08-28 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26 18:03 [Bug tree-optimization/107880] New: " pinskia at gcc dot gnu.org
2022-11-26 18:06 ` [Bug tree-optimization/107880] " pinskia at gcc dot gnu.org
2022-11-26 18:11 ` pinskia at gcc dot gnu.org
2023-05-24  1:15 ` pinskia at gcc dot gnu.org
2023-08-28 20:36 ` pinskia at gcc dot gnu.org
2023-08-28 21:30 ` pinskia at gcc dot gnu.org
2023-08-28 22:52 ` pinskia at gcc dot gnu.org [this message]
2023-09-12 15:03 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107880-4-HtqTH0GkE7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).