From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 616103858004; Thu, 30 Mar 2023 11:23:59 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 616103858004
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1680175439;
	bh=OwxOTY/0lChVnAP6iGvjbcuiRNa6UKL2A29zn7nCQjY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=uXMvfl8YQEHj3GtT9MHIfJ8zeStqMM7GucpKkg4ou1/a7zYKDOm3GDy9CYdVq58NI
	 gsG+8AD2jZoSe1z0yvZpeZZW8zz7B372Qxx2A1d+7sQrnbAmi6wLBNPs6093XWOvGE
	 LL9+/64knJToKmphhDwIPK2CXVg6Xss+mYB9G4NI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/107897] [13 Regression] mangling conflicts with a previous
 mangle since r13-3601
Date: Thu, 30 Mar 2023 11:23:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ABI, c++-lambda, rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jason at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107897-4-EIGL9dfcFN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107897-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107897-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107897

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:a23b33a1bdeff7bc2289d9ebb7cb7b7ec0a605f5

commit r13-6944-ga23b33a1bdeff7bc2289d9ebb7cb7b7ec0a605f5
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Mar 6 15:33:45 2023 -0500

    c++: lambda mangling alias issues [PR107897]

    In 107897, by the time we are looking at the mangling clash, the
    alias has already been removed from the symbol table by analyze_functio=
ns,
    so we can't look at n->cpp_implicit_alias.  So just assume that it's an
    alias if it's internal.

    In 108887 the problem is that removing the mangling alias from the symb=
ol
    table confuses analyze_functions, because it ended up as first_analyzed
    somehow, so it becomes a dangling pointer.  So instead we call reset()
    to neutralize the alias.  To make this work for variables, I needed to =
move
    reset() from cgraph_node to symtab_node.

            PR c++/107897
            PR c++/108887

    gcc/ChangeLog:

            * cgraph.h: Move reset() from cgraph_node to symtab_node.
            * cgraphunit.cc (symtab_node::reset): Adjust.  Also call
            remove_from_same_comdat_group.

    gcc/cp/ChangeLog:

            * decl2.cc (record_mangling): Use symtab_node::reset.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/concepts-lambda3.C: Use -flto if supported.
            * g++.dg/cpp0x/lambda/lambda-mangle7.C: New test.=