From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 0B3A93858C52; Mon, 28 Nov 2022 21:11:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B3A93858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1669669866; bh=1g0HqVGgyIw1ETHtytAPQVqVuBT5CzrMKxwdYoKLBMI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=n7P12u8EYBD0ejb8IwEF0VtN9lRqHpysfwGCgP+0rFrPOibo70IFfAn91OB/8RAbg dWfJQ/Lr2BSbBXIWMnR2nZghNXfmmG/h3m5k5NHrQLp4zgZp1S4UOHUn4GpGnvvpGj jlEG1o9e5uXSxYPwM9tntnwBKfHQEUiQXzAQEFf0= From: "redi at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/107901] std::format isn't usable on 16-bit targets Date: Mon, 28 Nov 2022 21:11:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: rejects-valid X-Bugzilla-Severity: normal X-Bugzilla-Who: redi at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: everconfirmed cf_reconfirmed_on bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107901 Jonathan Wakely changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Last reconfirmed| |2022-11-28 Status|UNCONFIRMED |NEW --- Comment #1 from Jonathan Wakely --- This allows the file to be compiled: --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -3035,12 +3035,21 @@ namespace __format case _Arg_ull: return std::forward<_Visitor>(__vis)(_M_val._M_ull); case _Arg_flt: - return std::forward<_Visitor>(__vis)(_M_val._M_flt); + if constexpr (__formattable_float) + return std::forward<_Visitor>(__vis)(_M_val._M_flt); + else + return std::forward<_Visitor>(__vis)(_M_val._M_none); case _Arg_dbl: - return std::forward<_Visitor>(__vis)(_M_val._M_dbl); + if constexpr (__formattable_float) + return std::forward<_Visitor>(__vis)(_M_val._M_dbl); + else + return std::forward<_Visitor>(__vis)(_M_val._M_none); #ifndef _GLIBCXX_LONG_DOUBLE_ALT128_COMPAT case _Arg_ldbl: - return std::forward<_Visitor>(__vis)(_M_val._M_ldbl); + if constexpr (__formattable_float) + return std::forward<_Visitor>(__vis)(_M_val._M_ldbl); + else + return std::forward<_Visitor>(__vis)(_M_val._M_none); #else case _Arg_f128: return std::forward<_Visitor>(__vis)(_M_val._M_f128);=