public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/107925] ICE in update_specialized_profile at gcc/ipa-cp.cc:5082 for 531.deepsjeng_r benchmark
Date: Wed, 22 Mar 2023 16:05:05 +0000	[thread overview]
Message-ID: <bug-107925-4-EDMwZCAngM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107925-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107925

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:c826442f6651bab6f66d3107fb02d38eacbf900e

commit r12-9308-gc826442f6651bab6f66d3107fb02d38eacbf900e
Author: Martin Jambor <mjambor@suse.cz>
Date:   Wed Mar 22 16:59:45 2023 +0100

    ipa-cp: Fix various issues in update_specialized_profile (PR 107925)

    The patch below fixes various issues in function
    update_specialized_profile.  The main is removal of the assert which
    is bogus in the case of recursive cloning.  The division of
    unexplained counts is guesswork, which then leads to updates of counts
    of recursive edges, which then can be redirected to the new clone and
    their count subtracted from the count and there simply may not be
    enough left in the count of the original node - especially when we
    clone a lot because of using --param ipa-cp-eval-threshold=1.

    The other issue was omission to drop the count of the original node to
    ipa count.  And when calculating the remainder, we should use
    lenient_count_portion_handling to account for partial train runs.
    Finally, the patch adds dumping of the original count which I think
    is useful.

    gcc/ChangeLog:

    2023-02-17  Martin Jambor  <mjambor@suse.cz>

            PR ipa/107925
            * ipa-cp.cc (update_specialized_profile): Drop orig_node_count to
            ipa count, remove assert, lenient_count_portion_handling, dump
            also orig_node_count.

    (cherry picked from commit 68ba253bda74d6c6e77726d98184a6faee5e7337)

  parent reply	other threads:[~2023-03-22 16:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 20:46 [Bug ipa/107925] New: " marxin at gcc dot gnu.org
2022-11-29 20:46 ` [Bug ipa/107925] " marxin at gcc dot gnu.org
2022-11-29 20:46 ` marxin at gcc dot gnu.org
2022-11-29 20:47 ` marxin at gcc dot gnu.org
2022-11-29 20:58 ` pinskia at gcc dot gnu.org
2023-01-27 10:15 ` tnfchris at gcc dot gnu.org
2023-02-17 17:20 ` jamborm at gcc dot gnu.org
2023-02-22  9:55 ` jamborm at gcc dot gnu.org
2023-03-14 17:57 ` cvs-commit at gcc dot gnu.org
2023-03-14 17:57 ` cvs-commit at gcc dot gnu.org
2023-03-14 17:58 ` jamborm at gcc dot gnu.org
2023-03-22 16:05 ` cvs-commit at gcc dot gnu.org [this message]
2023-03-22 16:06 ` jamborm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107925-4-EDMwZCAngM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).