From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 0683C3858C2D; Tue, 14 Mar 2023 17:57:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0683C3858C2D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1678816634;
	bh=TFoh1nsClMbboreiDbcGlyu361pjKC4pv4pMmEPm71g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Wy5JFmkIJJ6b/3IxJjgiGfE94vpe0/k2IadSljOtsDA+oTGri/EWSwCZ3wuYt++ad
	 C4CSI4BxTxn/lY36AWrCSGuds33MGFoKBkh1a0UxCCFkHs8HYJUYp/aa6eyj4V/l8F
	 mG/11ffiO6I1W4Nce1ULTm8az0J1u7G/HHNk5vyg=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/107925] ICE in update_specialized_profile at
 gcc/ipa-cp.cc:5082 for 531.deepsjeng_r benchmark
Date: Tue, 14 Mar 2023 17:57:13 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107925-4-c399G8Nb9x@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107925-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107925-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107925

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:68ba253bda74d6c6e77726d98184a6faee5e7337

commit r13-6666-g68ba253bda74d6c6e77726d98184a6faee5e7337
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Mar 14 18:53:16 2023 +0100

    ipa-cp: Fix various issues in update_specialized_profile (PR 107925)

    The patch below fixes various issues in function
    update_specialized_profile.  The main is removal of the assert which
    is bogus in the case of recursive cloning.  The division of
    unexplained counts is guesswork, which then leads to updates of counts
    of recursive edges, which then can be redirected to the new clone and
    their count subtracted from the count and there simply may not be
    enough left in the count of the original node - especially when we
    clone a lot because of using --param ipa-cp-eval-threshold=3D1.

    The other issue was omission to drop the count of the original node to
    ipa count.  And when calculating the remainder, we should use
    lenient_count_portion_handling to account for partial train runs.
    Finally, the patch adds dumping of the original count which I think
    is useful.

    gcc/ChangeLog:

    2023-02-17  Martin Jambor  <mjambor@suse.cz>

            PR ipa/107925
            * ipa-cp.cc (update_specialized_profile): Drop orig_node_count =
to
            ipa count, remove assert, lenient_count_portion_handling, dump
            also orig_node_count.=