From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 454C63858D1E; Fri, 12 Jan 2024 11:56:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 454C63858D1E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1705060593;
	bh=5QjcEIjSy0lzsDHCfHvhT3M8Tr+y8r8k88Pj6Egqo8s=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=wzOXbx6mVI/pN2ZtJ81uNK2OJtt7DvXVaimD6+wlcDPjFIVpkVnhprW5d/elEd2n/
	 khAJD2kEcbiHswmP0DLosOrdg1rfVnwb4Dh3h5NSMu/BK/b4eBtDk9pU0zYus3RCam
	 uJOotja048RAMa1dN+12uut+OCErfmv50uWWUyoY=
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/107931] [12/13/14 Regression] -Og causes always_inline to
 fail since r12-6677-gc952126870c92cf2
Date: Fri, 12 Jan 2024 11:56:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 12.2.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: INVALID
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107931-4-8ZJXacBLbt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107931-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107931-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107931

--- Comment #24 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #23)
> Couldn't we conditionalize that
>       if (!opt_for_fn (node->decl, optimize)
>          /* With -Og we do not want to perform IPA inlining of small
>             functions since there are no scalar cleanups after it
>             that would realize the anticipated win.  All abstraction
>             is removed during early inlining.  */
>          || opt_for_fn (node->decl, optimize_debug))
>         continue;
> on the callee not being always_inline?

You mean on there being no always_inline callee?  This iterates over
the functions we inline _into_.  We don't really special-case always-inline
during IPA since we expect all of them inlined early.

But yes, that would probably mean skipping non-always-inline edges
during enqueueing calls.=