public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nruslan_devel at yahoo dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/107958] New: Ambiguity with uniform initialization in overloaded operator and explicit constructor
Date: Sat, 03 Dec 2022 16:48:22 +0000	[thread overview]
Message-ID: <bug-107958-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107958

            Bug ID: 107958
           Summary: Ambiguity with uniform initialization in overloaded
                    operator and explicit constructor
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nruslan_devel at yahoo dot com
  Target Milestone: ---

Suppose we have the following example with a class that has to keep two
pointers. (I actually encountered this error with a more complex example, but
this one is just for illustration.) The problem arises when I attempt to use
the assignment operator and curly braces.

If I understand correctly, two possibilities exist when passing curly braces:

1. Use the overloaded operator= (implicitly convert curly braces to a pair). In
this particular example, we could have probably used make_pair but I
deliberately put curly braces to show how this error is triggered.

2. Use the constructor to create a new PairPtr instance and then copy it to the
old object through operator=

Both clang and gcc complain unless I mark the corresponding constructor as
'explicit'. To avoid the ambiguity with the second case, I mark the
corresponding constructor as 'explicit' and expect that the overloaded
operator= to be used. That seems to work with clang/llvm but not with gcc (see
the error below).

#include <iostream>
#include <utility>

struct PairPtr {

    PairPtr() {}

    PairPtr(const PairPtr &s) {
        a = s.a;
        b = s.b;
    }

    explicit PairPtr(int *_a, int *_b) {
        a = _a;
        b = _b;
    }

    PairPtr& operator=(const PairPtr &s) {
        a = s.a;
        b = s.b;
        return *this;
    }

    PairPtr& operator=(const std::pair<int *, int *>& pair) {
        a = pair.first;
        b = pair.second;
        return *this;
    }

    int *a;
    int *b;
};

void func(int *a, int *b)
{
    PairPtr p;

    p = { a, b };
}


Error (note that clang/llvm can compile the above code successfully!):

Note that 'explicit' for the constructor fixes the problem for clang/llvm but
does not fix the problem for gcc.

2.cpp: In function ‘void func(int*, int*)’:
2.cpp:38:20: error: ambiguous overload for ‘operator=’ (operand types are
‘PairPtr’ and ‘<brace-enclosed initializer list>’)
   38 |         p = { a, b };
      |                    ^
2.cpp:18:18: note: candidate: ‘PairPtr& PairPtr::operator=(const PairPtr&)’
   18 |         PairPtr& operator=(const PairPtr &s) {
      |                  ^~~~~~~~
2.cpp:24:18: note: candidate: ‘PairPtr& PairPtr::operator=(const
std::pair<int*, int*>&)’
   24 |         PairPtr& operator=(const std::pair<int *, int *>& pair) {
      |

             reply	other threads:[~2022-12-03 16:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03 16:48 nruslan_devel at yahoo dot com [this message]
2022-12-03 17:01 ` [Bug c++/107958] " pinskia at gcc dot gnu.org
2022-12-03 17:05 ` pinskia at gcc dot gnu.org
2022-12-03 17:11 ` pinskia at gcc dot gnu.org
2022-12-03 18:12 ` pinskia at gcc dot gnu.org
2022-12-03 18:22 ` pinskia at gcc dot gnu.org
2022-12-03 18:46 ` pinskia at gcc dot gnu.org
2022-12-03 18:49 ` pinskia at gcc dot gnu.org
2022-12-03 18:50 ` pinskia at gcc dot gnu.org
2022-12-04  4:19 ` nruslan_devel at yahoo dot com
2022-12-04  4:39 ` nruslan_devel at yahoo dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107958-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).