public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aaron at aaronballman dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/107980] va_start does not warn about an arbitrary number of arguments in C2x mode
Date: Wed, 07 Dec 2022 15:00:00 +0000	[thread overview]
Message-ID: <bug-107980-4-6KpnhUIxAT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107980-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107980

--- Comment #14 from Aaron Ballman <aaron at aaronballman dot com> ---
(In reply to joseph@codesourcery.com from comment #12)
> The standard rule about not using extra arguments means that any warnings 
> would need to avoid even converting those arguments from pp-tokens to 
> tokens; it's OK for them to contain pp-tokens that cannot be converted to 
> tokens.

Agreed, that's why I filed an NB comment to remove the restriction that the
arguments can't be expanded. Hopefully WG14 will relax that so we can give good
diagnostic behavior.

> I think the accepted change to the standard was entirely clear about 
> ignoring the extra arguments; it wasn't some obscure non-obvious 
> consequence that such code would become valid.

It was not discussed in the paper, or the meeting minutes, or my personal
notes. I may have missed something, but I have no reason to believe WG14
explicitly considered the ramifications of this. Also, I cannot find another
instance where a function-like macro accepts arguments that it is not allowed
to *expand*; that's a novel WG14 invention.

Also, it was a potentially silently breaking change (if you don't mind horribly
contrived examples of breakage): https://godbolt.org/z/T4bG6179f

  parent reply	other threads:[~2022-12-07 15:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 20:46 [Bug c/107980] New: va_start incorrectly accepts an arbitrary number of arguments in C2x aaron at aaronballman dot com
2022-12-05 20:57 ` [Bug c/107980] " pinskia at gcc dot gnu.org
2022-12-05 21:04 ` aaron at aaronballman dot com
2022-12-05 21:10 ` [Bug c/107980] va_start does not warn about an arbitrary number of arguments in C2x mode pinskia at gcc dot gnu.org
2022-12-05 21:17 ` pinskia at gcc dot gnu.org
2022-12-06 13:37 ` aaron at aaronballman dot com
2022-12-06 13:44 ` pinskia at gcc dot gnu.org
2022-12-06 13:51 ` jakub at gcc dot gnu.org
2022-12-06 14:04 ` aaron at aaronballman dot com
2022-12-06 15:42 ` aaron at aaronballman dot com
2022-12-06 15:46 ` jakub at gcc dot gnu.org
2022-12-06 16:13 ` aaron at aaronballman dot com
2022-12-07  0:55 ` joseph at codesourcery dot com
2022-12-07 14:57 ` jakub at gcc dot gnu.org
2022-12-07 15:00 ` aaron at aaronballman dot com [this message]
2022-12-07 15:38 ` pinskia at gcc dot gnu.org
2022-12-07 16:42 ` aaron at aaronballman dot com
2022-12-07 18:29 ` joseph at codesourcery dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107980-4-6KpnhUIxAT@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).