public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/107980] va_start does not warn about an arbitrary number of arguments in C2x mode Date: Wed, 07 Dec 2022 14:57:19 +0000 [thread overview] Message-ID: <bug-107980-4-c8Lqi5ejaB@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107980-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107980 --- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Warning for 3 or more arguments using preprocessor stuff only could look like: #define __va_start_2() #define __va_start_23(...) __builtin_warning ("too many va_arg arguments"); #define __va_start_1() #define __va_start_12(v, ...) __va_start_2##__VA_OPT__(3) (__VA_ARGS__) #define va_start(v, ...) __va_start_1##__VA_OPT__(2) (__VA_ARGS__) __builtin_va_start (v, 0) We are C2X here, so we can rely on __VA_OPT__. As for warning when there are 2 arguments and second argument is not identifier for the last argument, in the light of #c12 that would be fairly difficult. In the preprocessor it is going to be pretty hard to find out whether in the 2 arguments case the second one is a single identifier token, and on the compiler side __builtin_va_start or __builtin_va_start_c23 would need to be a keyword with its own parsing which would parse normally as expression the first argument, but for the rest just warn if it is more than 2 arguments or second argument is present and is not identifier of the last argument, but otherwise ignore the tokens. Still, isn't say: #define A ( #define B ) va_start (ap, A B B ); va_start (ap, A A A ); valid in C2X? That ruins both the argument counting and especially any attempts to decide something after preprocessing.
next prev parent reply other threads:[~2022-12-07 14:57 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-05 20:46 [Bug c/107980] New: va_start incorrectly accepts an arbitrary number of arguments in C2x aaron at aaronballman dot com 2022-12-05 20:57 ` [Bug c/107980] " pinskia at gcc dot gnu.org 2022-12-05 21:04 ` aaron at aaronballman dot com 2022-12-05 21:10 ` [Bug c/107980] va_start does not warn about an arbitrary number of arguments in C2x mode pinskia at gcc dot gnu.org 2022-12-05 21:17 ` pinskia at gcc dot gnu.org 2022-12-06 13:37 ` aaron at aaronballman dot com 2022-12-06 13:44 ` pinskia at gcc dot gnu.org 2022-12-06 13:51 ` jakub at gcc dot gnu.org 2022-12-06 14:04 ` aaron at aaronballman dot com 2022-12-06 15:42 ` aaron at aaronballman dot com 2022-12-06 15:46 ` jakub at gcc dot gnu.org 2022-12-06 16:13 ` aaron at aaronballman dot com 2022-12-07 0:55 ` joseph at codesourcery dot com 2022-12-07 14:57 ` jakub at gcc dot gnu.org [this message] 2022-12-07 15:00 ` aaron at aaronballman dot com 2022-12-07 15:38 ` pinskia at gcc dot gnu.org 2022-12-07 16:42 ` aaron at aaronballman dot com 2022-12-07 18:29 ` joseph at codesourcery dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107980-4-c8Lqi5ejaB@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).