public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu
Date: Wed, 14 Dec 2022 13:54:51 +0000	[thread overview]
Message-ID: <bug-107988-4-FBkarLtu0V@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107988-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:8c2451ba4601739654e2ea4907d6fa2a00d660aa

commit r13-4699-g8c2451ba4601739654e2ea4907d6fa2a00d660aa
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Dec 14 13:54:28 2022 +0000

    AArch64: div-by-255, ensure that arguments are registers. [PR107988]

    At -O0 (as opposed to e.g. volatile) we can get into the situation where
the
    in0 and result RTL arguments passed to the division function are memory
    locations instead of registers.  I think we could reject these early on by
    checking that the gimple values are GIMPLE registers, but I think it's
better to
    handle it.

    As such I force them to registers and emit a move to the memory locations
and
    leave it up to reload to handle.  This fixes the ICE and still allows the
    optimization in these cases,  which improves the code quality a lot.

    gcc/ChangeLog:

            PR target/107988
            * config/aarch64/aarch64.cc
            (aarch64_vectorize_can_special_div_by_constant): Ensure input and
output
            RTL are registers.

    gcc/testsuite/ChangeLog:

            PR target/107988
            * gcc.target/aarch64/pr107988-1.c: New test.

  parent reply	other threads:[~2022-12-14 13:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 11:26 [Bug target/107988] New: " zsojka at seznam dot cz
2022-12-06 11:55 ` [Bug target/107988] " ktkachov at gcc dot gnu.org
2022-12-06 12:22 ` tnfchris at gcc dot gnu.org
2022-12-06 16:33 ` rguenth at gcc dot gnu.org
2022-12-14 13:54 ` cvs-commit at gcc dot gnu.org [this message]
2022-12-14 13:55 ` tnfchris at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107988-4-FBkarLtu0V@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).