public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
Date: Tue, 02 May 2023 20:12:35 +0000	[thread overview]
Message-ID: <bug-107997-4-YL13gkeutA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107997-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:5a0fd69bb3aa1709f0bea5d6b91fb30ca226c1ed

commit r11-10687-g5a0fd69bb3aa1709f0bea5d6b91fb30ca226c1ed
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Dec 10 16:50:39 2022 +0100

    ivopts: Fix IP_END handling for asm goto [PR107997]

    The following testcase ICEs, because the latch bb ends with
    asm goto which has both fallthrough to the header and one or more labels
    in the header too.  In that case there is just a single edge out of the
    latch block, but still the asm goto is stmt_ends_bb_p statement, yet
    ivopts decides to emit an IV bump at the IP_END position and inserts
    it into the same bb as the asm goto after it, which then fails verification
    (control flow in the middle of bb).

    The following patch fixes it by splitting the latch -> header edge in that
    case and inserting into the newly created bb, where split_edge ->
    redirect_edge_and_branch is able to deal with this case correctly.

    2022-12-10  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/107997
            * tree-ssa-loop-ivopts.c: Include cfganal.h.
            (create_new_iv) <case IP_END>: If ip_end_pos bb is non-empty and
ends
            with a stmt which ends bb, instead of adding iv update after it
split
            the latch edge and insert iterator into the new latch bb.

            * gcc.c-torture/compile/pr107997.c: New test.

    (cherry picked from commit 7676235f690e624b7ed41a22b22ce8ccfac1492f)

  parent reply	other threads:[~2023-05-02 20:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 " jbglaw@lug-owl.de
2022-12-07  0:08 ` [Bug tree-optimization/107997] [13 Regression] " pinskia at gcc dot gnu.org
2022-12-08 17:41 ` [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 " jakub at gcc dot gnu.org
2022-12-08 18:07 ` jbglaw@lug-owl.de
2022-12-08 18:47 ` jbglaw@lug-owl.de
2022-12-08 18:47 ` jbglaw@lug-owl.de
2022-12-08 18:55 ` jakub at gcc dot gnu.org
2022-12-08 19:18 ` jakub at gcc dot gnu.org
2022-12-08 19:22 ` [Bug tree-optimization/107997] [10/11/12/13 " pinskia at gcc dot gnu.org
2022-12-08 19:50 ` jakub at gcc dot gnu.org
2022-12-09 13:49 ` jakub at gcc dot gnu.org
2022-12-09 18:27 ` jbglaw@lug-owl.de
2022-12-10 15:51 ` cvs-commit at gcc dot gnu.org
2022-12-14 10:33 ` jbglaw@lug-owl.de
2023-02-10 17:44 ` cvs-commit at gcc dot gnu.org
2023-02-10 17:58 ` jakub at gcc dot gnu.org
2023-05-02 20:12 ` cvs-commit at gcc dot gnu.org [this message]
2023-05-03  9:33 ` jakub at gcc dot gnu.org
2023-05-03 15:19 ` cvs-commit at gcc dot gnu.org
2023-05-04  7:22 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107997-4-YL13gkeutA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).