public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/108042] [10/11/12/13 Regression] weakref on an extern decl is incorrectly ignored Date: Sun, 11 Dec 2022 12:36:36 +0000 [thread overview] Message-ID: <bug-108042-4-vOGqVwNqbs@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108042-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108042 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Last reconfirmed| |2022-12-11 Ever confirmed|0 |1 CC| |hubicka at gcc dot gnu.org, | |rguenth at gcc dot gnu.org Target Milestone|--- |10.5 Status|UNCONFIRMED |WAITING --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> --- t2.c:1:6: warning: 'weakref' attribute should be accompanied with an 'alias' attribute [-Wattributes] 1 | void KNOWNNOTOBEAFUNCTION(void) __attribute__((weakref)); | ^~~~~~~~~~~~~~~~~~~~ did you want to use __attribute__((weak)) here? I think this works as designed. Note handle_weakref_attribute has /* The idea here is that `weakref("name")' mutates into `weakref, alias("name")', and weakref without arguments, in turn, implicitly adds weak. */ if (args) { attr = tree_cons (get_identifier ("alias"), args, attr); attr = tree_cons (get_identifier ("weakref"), NULL_TREE, attr); *no_add_attrs = true; decl_attributes (node, attr, flags); } else { if (lookup_attribute ("alias", DECL_ATTRIBUTES (*node))) error_at (DECL_SOURCE_LOCATION (*node), "%qE attribute must appear before %qs attribute", name, "alias"); /* Can't call declare_weak because it wants this to be TREE_PUBLIC, and that isn't supported; and because it wants to add it to the list of weak decls, which isn't helpful. */ DECL_WEAK (*node) = 1; but then process_common_attributes does tree weakref = lookup_attribute ("weakref", DECL_ATTRIBUTES (decl)); if (weakref && !lookup_attribute ("alias", DECL_ATTRIBUTES (decl))) { warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wattributes, "%<weakref%> attribute should be accompanied with" " an %<alias%> attribute"); DECL_WEAK (decl) = 0; DECL_ATTRIBUTES (decl) = remove_attribute ("weakref", DECL_ATTRIBUTES (decl)); } this diagnostic does not match the documentation which gives the plain 'weakref' semantics of 'weak'.
next prev parent reply other threads:[~2022-12-11 12:36 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-10 3:42 [Bug middle-end/108042] New: " pinskia at gcc dot gnu.org 2022-12-10 3:43 ` [Bug middle-end/108042] " pinskia at gcc dot gnu.org 2022-12-11 12:36 ` rguenth at gcc dot gnu.org [this message] 2022-12-11 13:12 ` rguenth at gcc dot gnu.org 2023-07-07 10:44 ` [Bug middle-end/108042] [11/12/13/14 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108042-4-vOGqVwNqbs@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).