public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/108086] [11/12/13 Regression] internal compiler error: in set_accesses, at rtl-ssa/internals.inl:449
Date: Thu, 02 Feb 2023 10:41:23 +0000	[thread overview]
Message-ID: <bug-108086-4-d7ITWBxE93@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108086-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108086

--- Comment #16 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #13)
> (In reply to Richard Biener from comment #12)
> > A regression from GCC 10 which compiles this in 90s at -O1.
> > 
> > Richard?  Can you please look at this special-case of BB0 insn_info?
> 
> The following might be one way to "fix" it (until we do a bigger testcase)
> 
> diff --git a/gcc/rtl-ssa/insns.h b/gcc/rtl-ssa/insns.h
> index f7215972845..b0144f258b2 100644
> --- a/gcc/rtl-ssa/insns.h
> +++ b/gcc/rtl-ssa/insns.h
> @@ -403,8 +403,7 @@ private:
>    // MAX_RECOG_OPERANDS is the maximum number of pseudos that can be
>    // defined by an instruction, so the number of definitions should fit
>    // easily in 16 bits.
> -  unsigned int m_num_uses;
> -  unsigned int m_num_defs : 16;
> +  unsigned int m_num_uses : 24;
The problem is that:

  // The number of definitions and the number uses.  FIRST_PSEUDO_REGISTER + 1
  // is the maximum number of accesses to hard registers and memory, and
  // MAX_RECOG_OPERANDS is the maximum number of pseudos that can be
  // defined by an instruction, so the number of definitions should fit
  // easily in 16 bits.

holds for real instructions, but not for artificial instructions.
Since we don't have any new justification for a limit less than 32 bits,
I think we'll just have to grow the structure.

  parent reply	other threads:[~2023-02-02 10:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 18:40 [Bug c++/108086] New: " jonas.keller@uni-bielefeld.de
2022-12-13 18:42 ` [Bug c++/108086] " jonas.keller@uni-bielefeld.de
2022-12-13 18:43 ` jonas.keller@uni-bielefeld.de
2022-12-13 18:43 ` jonas.keller@uni-bielefeld.de
2022-12-14  8:35 ` [Bug rtl-optimization/108086] " rguenth at gcc dot gnu.org
2022-12-14  8:47 ` rguenth at gcc dot gnu.org
2022-12-14 10:53 ` marxin at gcc dot gnu.org
2022-12-15 10:30 ` rguenth at gcc dot gnu.org
2022-12-15 10:32 ` cvs-commit at gcc dot gnu.org
2022-12-15 17:43 ` cvs-commit at gcc dot gnu.org
2022-12-16  8:30 ` cvs-commit at gcc dot gnu.org
2022-12-16  9:29 ` cvs-commit at gcc dot gnu.org
2022-12-16 11:27 ` [Bug rtl-optimization/108086] [11/12/13 Regression] " rguenth at gcc dot gnu.org
2022-12-16 11:32 ` rguenth at gcc dot gnu.org
2022-12-16 12:06 ` cvs-commit at gcc dot gnu.org
2022-12-16 18:21 ` rsandifo at gcc dot gnu.org
2023-02-02 10:41 ` rsandifo at gcc dot gnu.org [this message]
2023-02-02 14:53 ` cvs-commit at gcc dot gnu.org
2023-04-03  8:57 ` [Bug rtl-optimization/108086] [11/12 " cvs-commit at gcc dot gnu.org
2023-04-14 13:15 ` [Bug rtl-optimization/108086] [11 " hubicka at gcc dot gnu.org
2023-05-29 10:07 ` jakub at gcc dot gnu.org
2024-02-19 13:43 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108086-4-d7ITWBxE93@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).