public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/108098] OpenMP/nvptx reverse offload execution test FAILs Date: Fri, 05 May 2023 09:28:25 +0000 [thread overview] Message-ID: <bug-108098-4-Shsp6GGr7U@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108098-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108098 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>: https://gcc.gnu.org/g:4359724cba31b2645f6106266bef019c3d6ef16a commit r14-491-g4359724cba31b2645f6106266bef019c3d6ef16a Author: Tobias Burnus <tobias@codesourcery.com> Date: Fri May 5 11:27:32 2023 +0200 nvptx/mkoffload.cc: Add dummy proc for OpenMP rev-offload table [PR108098] Seemingly, the ptx JIT of CUDA <= 10.2 replaces function pointers in global variables by NULL if a translation does not contain any executable code. It works with CUDA 11.1. The code of this commit is about reverse offload; having NULL values disables the side of reverse offload during image load. Solution is the same as found by Thomas for a related issue: Adding a dummy procedure. Cf. the PR of this issue and Thomas' patch "nvptx: Support global constructors/destructors via 'collect2'" https://gcc.gnu.org/pipermail/gcc-patches/2022-December/607749.html As that approach also works here: Co-authored-by: Thomas Schwinge <thomas@codesourcery.com> gcc/ PR libgomp/108098 * config/nvptx/mkoffload.cc (process): Emit dummy procedure alongside reverse-offload function table to prevent NULL values of the function addresses.
next prev parent reply other threads:[~2023-05-05 9:28 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-14 11:48 [Bug libgomp/108098] New: " tschwinge at gcc dot gnu.org 2022-12-15 9:09 ` [Bug libgomp/108098] " vries at gcc dot gnu.org 2022-12-16 9:40 ` tschwinge at gcc dot gnu.org 2022-12-16 13:13 ` burnus at gcc dot gnu.org 2022-12-16 15:06 ` burnus at gcc dot gnu.org 2023-05-05 9:28 ` cvs-commit at gcc dot gnu.org [this message] 2023-05-08 21:15 ` cvs-commit at gcc dot gnu.org 2023-05-08 21:16 ` burnus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108098-4-Shsp6GGr7U@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).