public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/108099] [12/13 Regression] ICE with type alias with `signed __int128_t` Date: Wed, 14 Dec 2022 18:18:04 +0000 [thread overview] Message-ID: <bug-108099-4-T0ZNOprJMB@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108099-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108099 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jason at gcc dot gnu.org --- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Started with r12-8173-ge580f81d22d61153564959f08d9a6d3bcc7fd386 For using u128 = unsigned __int128_t; auto a = sizeof (u128); it doesn't ICE but changes behavior, before that commit a was 16, now it is 4. The reason for the ICE as well as 4 in there is because r12-8173 does: + type = DECL_ORIGINAL_TYPE (typedef_decl); + typedef_decl = NULL_TREE; which is fine for user typedefs, but for the internally created typedefs like __int128_t, __uint128_t, __builtin_va_list, dunno if others too DECL_ORIGINAL_TYPE is NULL. So, the question is if we should fix it by tweaking c-common.cc so that instead of say: if (targetm.scalar_mode_supported_p (TImode)) lang_hooks.decls.pushdecl (build_decl (UNKNOWN_LOCATION, TYPE_DECL, get_identifier ("__int128_t"), intTI_type_node)); do if (targetm.scalar_mode_supported_p (TImode)) { tree decl = build_decl (UNKNOWN_LOCATION, TYPE_DECL, get_identifier ("__int128_t"), intTI_type_node); DECL_ORIGINAL_TYPE (decl) = intTI_type_node; lang_hooks.decls.pushdecl (decl); } etc., or if it wouldn't be better or at least easier to: --- gcc/cp/decl.cc.jj 2022-12-05 11:10:37.528674260 +0100 +++ gcc/cp/decl.cc 2022-12-14 19:16:40.242926374 +0100 @@ -12442,7 +12442,8 @@ grokdeclarator (const cp_declarator *dec pedwarn (loc, OPT_Wpedantic, "%qs specified with %qT", key, type); ok = !flag_pedantic_errors; - type = DECL_ORIGINAL_TYPE (typedef_decl); + if (DECL_ORIGINAL_TYPE (typedef_decl)) + type = DECL_ORIGINAL_TYPE (typedef_decl); typedef_decl = NULL_TREE; } else if (declspecs->decltype_p) I'm going to test the latter.
next prev parent reply other threads:[~2022-12-14 18:18 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-14 11:52 [Bug c++/108099] New: ICE when parsing signed __int128_t typedef moritz.klammler at cetitec dot com 2022-12-14 12:20 ` [Bug c++/108099] " redi at gcc dot gnu.org 2022-12-14 12:23 ` redi at gcc dot gnu.org 2022-12-14 12:26 ` redi at gcc dot gnu.org 2022-12-14 13:12 ` moritz.klammler at cetitec dot com 2022-12-14 17:46 ` [Bug c++/108099] ICE with type alias with `signed __int_128_t` pinskia at gcc dot gnu.org 2022-12-14 17:54 ` [Bug c++/108099] ICE with type alias with `signed __int128_t` pinskia at gcc dot gnu.org 2022-12-14 17:58 ` [Bug c++/108099] [12/13 Regression] " pinskia at gcc dot gnu.org 2022-12-14 18:18 ` jakub at gcc dot gnu.org [this message] 2022-12-14 19:05 ` jakub at gcc dot gnu.org 2022-12-14 19:20 ` jakub at gcc dot gnu.org 2022-12-21 12:37 ` rguenth at gcc dot gnu.org 2022-12-21 18:14 ` ville.voutilainen at gmail dot com 2023-01-31 16:00 ` pinskia at gcc dot gnu.org 2023-02-01 0:51 ` pinskia at gcc dot gnu.org 2023-02-01 11:59 ` redi at gcc dot gnu.org 2023-02-01 19:07 ` pinskia at gcc dot gnu.org 2023-02-01 19:17 ` jakub at gcc dot gnu.org 2023-03-09 22:25 ` jason at gcc dot gnu.org 2023-03-10 3:57 ` cvs-commit at gcc dot gnu.org 2023-03-10 3:59 ` [Bug c++/108099] [12 " jason at gcc dot gnu.org 2023-03-10 10:33 ` jakub at gcc dot gnu.org 2023-04-18 20:45 ` cvs-commit at gcc dot gnu.org 2023-04-19 15:23 ` cvs-commit at gcc dot gnu.org 2023-04-19 16:53 ` cvs-commit at gcc dot gnu.org 2023-04-19 16:59 ` [Bug c++/108099] [12/13/14 " jason at gcc dot gnu.org 2023-04-20 7:44 ` cvs-commit at gcc dot gnu.org 2023-04-20 7:48 ` cvs-commit at gcc dot gnu.org 2023-04-21 19:33 ` cvs-commit at gcc dot gnu.org 2023-05-02 20:25 ` [Bug c++/108099] [12/13 " cvs-commit at gcc dot gnu.org 2023-05-08 12:26 ` rguenth at gcc dot gnu.org 2023-07-25 10:50 ` [Bug c++/108099] [12 " redi at gcc dot gnu.org 2023-08-11 21:21 ` cvs-commit at gcc dot gnu.org 2023-12-19 21:50 ` jason at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108099-4-T0ZNOprJMB@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).