public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/108153] Profiled lto bootstrap failure with modula2
Date: Wed, 21 Dec 2022 08:18:19 +0000 [thread overview]
Message-ID: <bug-108153-4-onXvhW7qvb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108153-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108153
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:88709c4a1e6f8b69a33897a1ab46b8d66c4569c4
commit r13-4824-g88709c4a1e6f8b69a33897a1ab46b8d66c4569c4
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Dec 21 09:10:35 2022 +0100
modula2: Fix lto profiledbootstrap on powerpc64le-linux and s390x-linux
[PR108153]
Lto profiledbootstrap was failing for me on {powerpc64le,s390x}-linux with
modula 2 enabled, with:
cc1gm2: internal compiler error: the location value is corrupt
0x11a3d2d m2assert_AssertLocation(unsigned int)
../../gcc/m2/gm2-gcc/m2assert.cc:40
0x11a3d2d m2statement_BuildAssignmentTree
../../gcc/m2/gm2-gcc/m2statement.cc:177
ICE. The problem was that caller (m2assert_AssertLocation used
location_t M2Options_OverrideLocation (location_t);
prototype with the libcpp/line-map.h
typedef unsigned int location_t;
typedef, but the callee defined in Modula 2 was using:
TYPE
location_t = INTEGER ;
and
PROCEDURE OverrideLocation (location: location_t) : location_t ;
Now, on powerpc64le-linux unsigned int is returned and passed zero extended
into 64-bits, while signed int is returned and passed sign-extended into
64-bits
and Modula 2 INTEGER is signed 32-bit type, so when the caller then
compared
M2Options_OverrideLocation (location) != location
and powerpc64le-linux performed the comparison as 64-bit compare, there
was a mismatch for location_t of 0x8000007 or others with the MSB set.
Fixed by making Modula 2 location_t a CARDINAL, which is 32-bit unsigned
type.
2022-12-21 Jakub Jelinek <jakub@redhat.com>
PR modula2/108153
* gm2-gcc/m2linemap.def (location_t): Use CARDINAL instead of
INTEGER.
next prev parent reply other threads:[~2022-12-21 8:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 7:57 [Bug modula2/108153] New: " jakub at gcc dot gnu.org
2022-12-17 8:00 ` [Bug modula2/108153] " jakub at gcc dot gnu.org
2022-12-17 22:09 ` jakub at gcc dot gnu.org
2022-12-18 9:32 ` gaius at gcc dot gnu.org
2022-12-19 8:38 ` marxin at gcc dot gnu.org
2022-12-19 17:02 ` jakub at gcc dot gnu.org
2022-12-20 15:28 ` jakub at gcc dot gnu.org
2022-12-20 15:37 ` jakub at gcc dot gnu.org
2022-12-20 15:39 ` jakub at gcc dot gnu.org
2022-12-20 16:35 ` segher at gcc dot gnu.org
2022-12-20 16:36 ` segher at gcc dot gnu.org
2022-12-20 18:01 ` gaius at gcc dot gnu.org
2022-12-21 8:18 ` cvs-commit at gcc dot gnu.org [this message]
2022-12-21 8:27 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-108153-4-onXvhW7qvb@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).