From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 380AB3858D33; Mon, 19 Dec 2022 15:47:49 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 380AB3858D33
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1671464869;
	bh=g4kb4KXj3HebcDEHrktuu5oIE8lMnMhNW1BwBqeZLdc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=wVxNAyn8q8ZE0qJURQIAUxS7Xs7qncwrcRZSvCagPym/oAJP1YIz+/kK/jbLjVDr0
	 N7LI8BsLKs4KUTSdbMMwSP023Zl8ImA6Xd9FqgQ3krxx3Etjf31pFxcOtOfbyUMsXl
	 koLTj5tvKIUYmPnzSY+hR8tQZEWHAJFcRXvSB71Y=
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/108177] MVE predicated stores to same address get
 optimized away
Date: Mon, 19 Dec 2022 15:47:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108177-4-CsXAMfaamG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108177-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108177-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108177

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I suspect

(insn 10 9 11 2 (set (mem:V16QI (reg/v/f:SI 117 [ pa ]) [0 MEM[(signed char=
[16]
*)pa_2(D)]+0 S16 A8])=20
        (unspec:V16QI [
                (reg/v:V16QI 116 [ a ])
                (reg:V16BI 120)
            ] VSTRBQ_U)) "include/arm_mve.h":12501:3 4673 {mve_vstrbq_p_uv1=
6qi}
     (nil))=20

isn't a very accurate description of a masked store.  On x86 we have

(insn 17 16 0 (set (mem:V8DI (reg/v/f:DI 87 [ p ]) [0  S64 A8])
        (vec_merge:V8DI (reg:V8DI 92)
            (mem:V8DI (reg/v/f:DI 87 [ p ]) [0  S64 A8])
            (subreg:QI (reg:SI 95) 0)))
"/home/rguenther/obj-trunk-g/gcc/include/avx512fintrin.h":6484:3 -1

For AVX we use:

(define_expand "maskstore<mode><sseintvecmodelower>"
  [(set (match_operand:V48_AVX2 0 "memory_operand")
    (unspec:V48_AVX2
      [(match_operand:<sseintvecmode> 2 "register_operand")
       (match_operand:V48_AVX2 1 "register_operand")
       (match_dup 0)]
      UNSPEC_MASKMOV))]
  "TARGET_AVX")

note how the memory destination is also an input to the UNSPEC here.=