public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/108183] wrong code generated in the modula2 scaffold mechanism
Date: Tue, 20 Dec 2022 20:21:13 +0000	[thread overview]
Message-ID: <bug-108183-4-GaV07pWrL1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108183-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108183

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> ---
So we do set _M2_termios_ctor Symbol to extern.

But then here:

      PreAddModGcc (Sym, BuildEndFunctionDeclaration (begin, end,
                                                      KeyToCharStar
(GetFullSymName (Sym)),
                                                      returnType,
                                                      IsExternal (Sym),  (*
Extern relative to the main module.  *)
                                                      IsProcedureGccNested
(Sym),
                                                      (* Exported from the
module where it was declared.  *)
                                                      IsExported
(GetModuleWhereDeclared (Sym), Sym) OR IsExtern (Sym))) ;
      PopBinding(scope) ;

"IsExternal (Sys)" returns false, because it thinks that the scope of
_M2_termios_ctor is HelloMod.

(lldb) p SymbolTable_GetScope(Sym)
(unsigned int) $5 = 155
(lldb) p M2GCCDeclare_PrintSym(155)
information about symbol: 155
==============================
sym 155 IsModule (HelloWorld)
(lldb) p Sym
(unsigned int) $6 = 6114

(lldb) p M2GCCDeclare_PrintSym(6114)
information about symbol: 6114
==============================
sym 6114 IsProcedure (_M2_termios_ctor) scope HelloWorld:1 155 extern ctor
declared in /source/test/hello.mod:1

So we create the decl assuming it exists in the TU .. which is the source of
the wrong code.

  parent reply	other threads:[~2022-12-20 20:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 23:45 [Bug modula2/108183] New: " iains at gcc dot gnu.org
2022-12-19 23:46 ` [Bug modula2/108183] " iains at gcc dot gnu.org
2022-12-19 23:57 ` iains at gcc dot gnu.org
2022-12-20  8:20 ` gaius at gcc dot gnu.org
2022-12-20  8:38 ` gaius at gcc dot gnu.org
2022-12-20  9:36 ` iains at gcc dot gnu.org
2022-12-20 10:00 ` iains at gcc dot gnu.org
2022-12-20 12:34 ` iains at gcc dot gnu.org
2022-12-20 12:37 ` iains at gcc dot gnu.org
2022-12-20 12:45 ` rguenth at gcc dot gnu.org
2022-12-20 20:21 ` iains at gcc dot gnu.org [this message]
2022-12-20 20:42 ` iains at gcc dot gnu.org
2022-12-20 21:24 ` gaius at gcc dot gnu.org
2022-12-21 15:35 ` iains at gcc dot gnu.org
2022-12-21 15:39 ` iains at gcc dot gnu.org
2022-12-24 17:19 ` iains at gcc dot gnu.org
2022-12-28 16:07 ` gaius at gcc dot gnu.org
2022-12-31 12:54 ` iains at gcc dot gnu.org
2022-12-31 12:57 ` iains at gcc dot gnu.org
2023-01-01  9:29 ` cvs-commit at gcc dot gnu.org
2023-01-02 11:21 ` iains at gcc dot gnu.org
2023-01-02 12:20 ` iains at gcc dot gnu.org
2023-01-04 14:55 ` cvs-commit at gcc dot gnu.org
2023-01-04 16:22 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108183-4-GaV07pWrL1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).