From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 441E8385840D; Wed,  4 Jan 2023 14:55:03 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 441E8385840D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1672844103;
	bh=J9UmcmZyx6zFtzSm2asHpFUV4ofli1rn6ZaZfdr/ccs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=D2opphkOxjOIt76zE0whQSrURj6DWYuixYhAONDGWwVv7Fyv+EBDLMsD+x3bdrrF4
	 zhovB6UpDy19sHOonTxbPdK96NyGCdWXLcwceirRQSQR9ZUVpVjonSm+a9GGt7zvUj
	 tzxsP0rtkIYVIkwdKt7cZzGsNE3cSKpcSUqjZuAg=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/108183] wrong code generated in the modula2 scaffold
 mechanism
Date: Wed, 04 Jan 2023 14:55:01 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: assemble-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108183-4-o7Cvxh8clJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108183-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108183-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108183

--- Comment #21 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:ec6d1fc09faea4a6be4df74babb73dca6b50ff0c

commit r13-4996-gec6d1fc09faea4a6be4df74babb73dca6b50ff0c
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Fri Dec 30 19:46:13 2022 +0000

    modula-2: Fix registration of modules via constructors [PR108183].

    This reworks the mechanism used for module registration to use init-
    time constructors.  The order of registration is not important, the
    actual initialization dependency tree will be computed early in the
    execution (all that matters is that we have registered before that).

    This fixes a potential issue in which the external name known to the
    m2 system is of the form _M2_XXXXXX_ctor() but the C++ code was
    producing a static variable instance with the same name.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

            PR modula2/108183

    gcc/m2/ChangeLog:

            * gm2-libs-ch/UnixArgs.cc (_M2_UnixArgs_ctor): Rework to use
            an extern "C" function with 'constructor' attribute.
            * gm2-libs-ch/dtoa.cc (_M2_dtoa_ctor): Likewise.
            * gm2-libs-ch/ldtoa.cc (_M2_ldtoa_ctor): Likewise.

    libgm2/ChangeLog:

            * libm2cor/KeyBoardLEDs.cc (_M2_KeyBoardLEDs_ctor): Rework to u=
se
            an extern "C" function with 'constructor' attribute.
            * libm2iso/ErrnoCategory.cc (_M2_ErrnoCategory_ctor): Likewise.
            * libm2iso/RTco.cc (_M2_RTco_ctor): Likewise.
            * libm2pim/Selective.cc (_M2_Selective_ctor): Likewise.
            * libm2pim/SysExceptions.cc (_M2_SysExceptions_ctor): Likewise.
            * libm2pim/UnixArgs.cc (_M2_UnixArgs_ctor): Likewise.
            * libm2pim/cgetopt.cc (_M2_cgetopt_ctor): Likewise.
            * libm2pim/dtoa.cc (_M2_dtoa_ctor): Likewise.
            * libm2pim/errno.cc (_M2_errno_ctor): Likewise.
            * libm2pim/ldtoa.cc (_M2_ldtoa_ctor): Likewise.
            * libm2pim/sckt.cc (_M2_sckt_ctor): Likewise.
            * libm2pim/termios.cc (_M2_termios_ctor): Likewise.
            * libm2pim/wrapc.c: Add a new line to the file end.=