From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 4A1B93858425; Tue, 20 Dec 2022 20:42:37 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A1B93858425
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1671568957;
	bh=5yWdV7MwRWo7UMWWRSw0tLUeL89+At6zz0B1sKYm5J8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=s/pv4IHhwixeRokEci9Uskd8uhGGmlJM3chGY5BZ51sTAv7ieN16/HJaigwv6NUSO
	 EWzTJ1W7Zi/PgQsqWvxhFGnm4wM3tDhWpp8ahsphjdTs7FFeeD+eZFvwPQCOruCVDw
	 /VYQRuufNVG5gEz4EB77q+bw+WcqCuexrZLST8jk=
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/108183] wrong code generated in the modula2 scaffold
 mechanism
Date: Tue, 20 Dec 2022 20:42:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: assemble-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108183-4-qZT9dGbBqR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108183-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108183-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108183

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> ---
It looks to me that we never check if Sym is a definition/implementation - =
only
that the containing scope is.

I probably miss something subtle - but perhaps

   IF NOT IsDefImp(Sym)
     RETURN ( TRUE )

before the mod :=3D line
?

(*
   IsExternal -
*)

PROCEDURE IsExternal (sym: CARDINAL) : BOOLEAN ;
VAR
   mod: CARDINAL ;
BEGIN
   mod :=3D GetScope(sym) ;
   REPEAT
      IF mod=3DNulSym
      THEN
         RETURN( FALSE )
      ELSIF IsDefImp(mod)
      THEN
         RETURN( mod#GetMainModule() )
      END ;
      mod :=3D GetScope(mod)
   UNTIL mod=3DNulSym ;
   RETURN( FALSE )
END IsExternal ;=