[Bug c++/108206] New: ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563

[Bug c++/108206] New: ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

            Bug ID: 108206
           Summary: ICE: tree check: expected tree that contains 'decl
                    minimal' structure, have 'error_mark' in
                    merge_default_template_args, at cp/decl.cc:1563
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 13.0.0 20221218 snapshot (g:fd69977febf399d1992bbf8d66ae9170e0a4dc9f) ICEs
when compiling the following testcase:

template <WrongType _IsMove, typename T1> void foo (T1);
template <WrongType _IsMove, typename T2> void foo (T2);

% g++-13 -c vph5xonf.cc
vph5xonf.cc:1:11: error: 'WrongType' has not been declared
    1 | template <WrongType _IsMove, typename T1> void foo (T1);
      |           ^~~~~~~~~
vph5xonf.cc:2:11: error: 'WrongType' has not been declared
    2 | template <WrongType _IsMove, typename T2> void bar (T2);
      |           ^~~~~~~~~
zsh: exit 1     g++-13 -c vph5xonf.cc
asolokha@czc101b91d ~/t1 % g++-13 -c vph5xonf.cc
vph5xonf.cc:1:11: error: 'WrongType' has not been declared
    1 | template <WrongType _IsMove, typename T1> void foo (T1);
      |           ^~~~~~~~~
vph5xonf.cc:2:11: error: 'WrongType' has not been declared
    2 | template <WrongType _IsMove, typename T2> void foo (T2);
      |           ^~~~~~~~~
vph5xonf.cc:2:55: error: redefinition of default argument for '<declaration
error>'
    2 | template <WrongType _IsMove, typename T2> void foo (T2);
      |                                                       ^
vph5xonf.cc:2:55: internal compiler error: tree check: expected tree that
contains 'decl minimal' structure, have 'error_mark' in
merge_default_template_args, at cp/decl.cc:1563
0x88468e tree_contains_struct_check_failed(tree_node const*,
tree_node_structure_enum, char const*, int, char const*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/tree.cc:8996
0x6d185d contains_struct_check(tree_node*, tree_node_structure_enum, char
const*, int, char const*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/tree.h:3642
0x6d185d merge_default_template_args(tree_node*, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/decl.cc:1563
0x9ff720 duplicate_decls(tree_node*, tree_node*, bool, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/decl.cc:2371
0xabdd4c pushdecl(tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/name-lookup.cc:3686
0xabf011 do_pushdecl_with_scope
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/name-lookup.cc:4769
0xabf23b pushdecl_namespace_level(tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/name-lookup.cc:6125
0xb70268 push_template_decl(tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/pt.cc:6128
0xa0d399 start_decl(cp_declarator const*, cp_decl_specifier_seq*, int,
tree_node*, tree_node*, tree_node**)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/decl.cc:5908
0xb10835 cp_parser_init_declarator
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:22854
0xb18d5e cp_parser_single_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:32459
0xb18f4c cp_parser_template_declaration_after_parameters
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:32012
0xb19860 cp_parser_explicit_template_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:32285
0xb1c504 cp_parser_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:14959
0xb1d051 cp_parser_toplevel_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:15051
0xb1d051 cp_parser_translation_unit
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:5090
0xb1d051 c_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cp/parser.cc:49389
0xc5d681 c_common_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c-family/c-opts.cc:1248

[Bug c++/108206] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

--- Comment #1 from Arseny Solokha <asolokha at gmx dot com> ---
> % g++-13 -c vph5xonf.cc
> vph5xonf.cc:1:11: error: 'WrongType' has not been declared
>     1 | template <WrongType _IsMove, typename T1> void foo (T1);
>       |           ^~~~~~~~~
> vph5xonf.cc:2:11: error: 'WrongType' has not been declared
>     2 | template <WrongType _IsMove, typename T2> void bar (T2);
>       |           ^~~~~~~~~
> zsh: exit 1     g++-13 -c vph5xonf.cc

Please ignore that part.

[Bug c++/108206] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE: tree check: expected   |ICE: tree check: expected
                   |tree that contains 'decl    |tree that contains 'decl
                   |minimal' structure, have    |minimal' structure, have
                   |'error_mark' in             |'error_mark' in
                   |merge_default_template_args |merge_default_template_args
                   |, at cp/decl.cc:1563        |, at cp/decl.cc:1563 since
                   |                            |r12-7562-gfe548eb8436f3906
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-12-23
   Target Milestone|---                         |12.3
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |ppalka at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-7562-gfe548eb8436f3906.

[Bug c++/108206] [12/13 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial
            Summary|ICE: tree check: expected   |[12/13 Regression] ICE:
                   |tree that contains 'decl    |tree check: expected tree
                   |minimal' structure, have    |that contains 'decl
                   |'error_mark' in             |minimal' structure, have
                   |merge_default_template_args |'error_mark' in
                   |, at cp/decl.cc:1563 since  |merge_default_template_args
                   |r12-7562-gfe548eb8436f3906  |, at cp/decl.cc:1563 since
                   |                            |r12-7562-gfe548eb8436f3906

[Bug c++/108206] [12/13 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54181
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54181&action=edit
gcc13-pr108206.patch

Untested fix.

[Bug c++/108206] [12/13 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:fc349931adcf1024ee95e0a0cd98cf4a41996093

commit r13-4999-gfc349931adcf1024ee95e0a0cd98cf4a41996093
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 4 18:42:31 2023 +0100

    c++: Error recovery in merge_default_template_args [PR108206]

    We ICE on the following testcase during error recovery, both new_parm
    and old_parm are error_mark_node, the ICE is on
              error ("redefinition of default argument for %q+#D", new_parm);
              inform (DECL_SOURCE_LOCATION (old_parm),
                      "original definition appeared here");
    where we don't print anything useful for new_parm and ICE trying to
    access DECL_SOURCE_LOCATION of old_parm.  I think we shouldn't diagnose
    anything when either of the parms is erroneous, GCC 11 before
    merge_default_template_args has been added was doing
          if (TREE_VEC_ELT (tmpl_parms, i) == error_mark_node
              || TREE_VEC_ELT (parms, i) == error_mark_node)
            continue;

          tmpl_parm = TREE_VALUE (TREE_VEC_ELT (tmpl_parms, i));
          if (error_operand_p (tmpl_parm))
            return false;
    in redeclare_class_template.

    2023-01-04  Jakub Jelinek  <jakub@redhat.com>

            PR c++/108206
            * decl.cc (merge_default_template_args): Return false if either
            new_parm or old_parm are erroneous.

            * g++.dg/template/pr108206.C: New test.

[Bug c++/108206] [12 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13 Regression] ICE:     |[12 Regression] ICE: tree
                   |tree check: expected tree   |check: expected tree that
                   |that contains 'decl         |contains 'decl minimal'
                   |minimal' structure, have    |structure, have
                   |'error_mark' in             |'error_mark' in
                   |merge_default_template_args |merge_default_template_args
                   |, at cp/decl.cc:1563 since  |, at cp/decl.cc:1563 since
                   |r12-7562-gfe548eb8436f3906  |r12-7562-gfe548eb8436f3906

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug c++/108206] [12 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0
           Priority|P3                          |P4

[Bug c++/108206] [12 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:7048e8c1073fcf2bf6be1a3d079393a78864ca61

commit r12-9137-g7048e8c1073fcf2bf6be1a3d079393a78864ca61
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 4 18:42:31 2023 +0100

    c++: Error recovery in merge_default_template_args [PR108206]

    We ICE on the following testcase during error recovery, both new_parm
    and old_parm are error_mark_node, the ICE is on
              error ("redefinition of default argument for %q+#D", new_parm);
              inform (DECL_SOURCE_LOCATION (old_parm),
                      "original definition appeared here");
    where we don't print anything useful for new_parm and ICE trying to
    access DECL_SOURCE_LOCATION of old_parm.  I think we shouldn't diagnose
    anything when either of the parms is erroneous, GCC 11 before
    merge_default_template_args has been added was doing
          if (TREE_VEC_ELT (tmpl_parms, i) == error_mark_node
              || TREE_VEC_ELT (parms, i) == error_mark_node)
            continue;

          tmpl_parm = TREE_VALUE (TREE_VEC_ELT (tmpl_parms, i));
          if (error_operand_p (tmpl_parm))
            return false;
    in redeclare_class_template.

    2023-01-04  Jakub Jelinek  <jakub@redhat.com>

            PR c++/108206
            * decl.cc (merge_default_template_args): Return false if either
            new_parm or old_parm are erroneous.

            * g++.dg/template/pr108206.C: New test.

    (cherry picked from commit fc349931adcf1024ee95e0a0cd98cf4a41996093)

[Bug c++/108206] [12 Regression] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'error_mark' in merge_default_template_args, at cp/decl.cc:1563 since r12-7562-gfe548eb8436f3906

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108206

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for gcc 12.3 too.