[Bug middle-end/108264] New: [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[Bug middle-end/108264] New: [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

            Bug ID: 108264
           Summary: [11/12/13 Regression] ICE compiling guacamole-server
                    on s390x-linux
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

int v;
extern int bar (void);

static inline void
foo (char *d)
{
  switch (bar ())
    {
    case 2:
      d[0] = d[1] = d[2] = d[3] = v;
      break;
    case 4:
      d[0] = 0;
    }
}

int
baz (int x)
{
  foo ((char *) &x);
  return x;
}

ICEs with -O2 -march=z13 -fpic (in 11 with -O2 -ftree-vectorize -march=z13
-fpic) in:
during RTL pass: expand
dump file: guacamole-ice.i.254r.expand
In function ‘foo’,
    inlined from ‘baz’ at guacamole-ice.i:20:3:
guacamole-ice.i:10:12: internal compiler error: in convert_move, at expr.cc:297
   10 |       d[0] = d[1] = d[2] = d[3] = v;
      |       ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
This is when expanding
  _2 = {_6, _6, _6, _6};
  MEM <vector(4) char> [(char *)&x] = _2;
where
  vector(4) char _2;
and x is int PARM_DECL.
to in convert_move is (reg/v:DI 66 [ x+-4 ]) and from is (reg:V4QI 70) , so the
modes have different sizes.  But x is actually int and so the DImode is
argument promotion.

[Bug middle-end/108264] [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |krebbel at gcc dot gnu.org
     Ever confirmed|0                           |1
           Priority|P3                          |P2
   Last reconfirmed|                            |2023-01-02
             Target|                            |s390x-linux
   Target Milestone|---                         |11.4

[Bug middle-end/108264] [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
store_expr is called with target (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4) where
the mode is still correct...

[Bug middle-end/108264] [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54175
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54175&action=edit
gcc13-pr108264.patch

Untested fix.

[Bug middle-end/108264] [11/12/13 Regression] ICE compiling guacamole-server on s390x-linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:226a498733e7919de72eb6f1bf3e16883ad159f6

commit r13-4975-g226a498733e7919de72eb6f1bf3e16883ad159f6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 3 12:13:24 2023 +0100

    expr: Fix up store_expr into SUBREG_PROMOTED_* target [PR108264]

    The following testcase ICEs on s390x-linux (e.g. with -march=z13).
    The problem is that target is (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4)
    and we call convert_move from temp to the SUBREG_REG of that, expecting
    to extend the value properly.  That works nicely if temp has some
    scalar integer mode (or partial one), but ICEs when temp has V4QImode
    on the assertion that from and to modes have the same bitsize.
    store_expr generally allows say store from V4QI to SI target because
    they have the same size and if temp is a CONST_INT, we already have code
    to convert the constant properly, so the following patch just adds handling
    of non-scalar integer modes by converting them to the mode of target
    first before convert_move extends them.

    2023-01-03  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/108264
            * expr.cc (store_expr): For stores into SUBREG_PROMOTED_* targets
            from source which doesn't have scalar integral mode first convert
            it to outer_mode.

            * gcc.dg/pr108264.c: New test.

[Bug middle-end/108264] [11/12 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13 Regression] ICE   |[11/12 Regression] ICE
                   |compiling guacamole-server  |compiling guacamole-server
                   |on s390x-linux              |on s390x-linux

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug middle-end/108264] [11/12 Regression] ICE compiling guacamole-server on s390x-linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ee25e54233c6a1548eda06aa9a11f09cd7eb32ac

commit r12-9135-gee25e54233c6a1548eda06aa9a11f09cd7eb32ac
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 3 12:13:24 2023 +0100

    expr: Fix up store_expr into SUBREG_PROMOTED_* target [PR108264]

    The following testcase ICEs on s390x-linux (e.g. with -march=z13).
    The problem is that target is (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4)
    and we call convert_move from temp to the SUBREG_REG of that, expecting
    to extend the value properly.  That works nicely if temp has some
    scalar integer mode (or partial one), but ICEs when temp has V4QImode
    on the assertion that from and to modes have the same bitsize.
    store_expr generally allows say store from V4QI to SI target because
    they have the same size and if temp is a CONST_INT, we already have code
    to convert the constant properly, so the following patch just adds handling
    of non-scalar integer modes by converting them to the mode of target
    first before convert_move extends them.

    2023-01-03  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/108264
            * expr.cc (store_expr): For stores into SUBREG_PROMOTED_* targets
            from source which doesn't have scalar integral mode first convert
            it to outer_mode.

            * gcc.dg/pr108264.c: New test.

    (cherry picked from commit 226a498733e7919de72eb6f1bf3e16883ad159f6)

[Bug middle-end/108264] [11 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12 Regression] ICE      |[11 Regression] ICE
                   |compiling guacamole-server  |compiling guacamole-server
                   |on s390x-linux              |on s390x-linux

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for gcc 12.3 too.

[Bug middle-end/108264] [11 Regression] ICE compiling guacamole-server on s390x-linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4e41fedf81fb08aa2204e16f2341c74711e022ae

commit r11-10696-g4e41fedf81fb08aa2204e16f2341c74711e022ae
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 3 12:13:24 2023 +0100

    expr: Fix up store_expr into SUBREG_PROMOTED_* target [PR108264]

    The following testcase ICEs on s390x-linux (e.g. with -march=z13).
    The problem is that target is (subreg/s/u:SI (reg/v:DI 66 [ x+-4 ]) 4)
    and we call convert_move from temp to the SUBREG_REG of that, expecting
    to extend the value properly.  That works nicely if temp has some
    scalar integer mode (or partial one), but ICEs when temp has V4QImode
    on the assertion that from and to modes have the same bitsize.
    store_expr generally allows say store from V4QI to SI target because
    they have the same size and if temp is a CONST_INT, we already have code
    to convert the constant properly, so the following patch just adds handling
    of non-scalar integer modes by converting them to the mode of target
    first before convert_move extends them.

    2023-01-03  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/108264
            * expr.c (store_expr): For stores into SUBREG_PROMOTED_* targets
            from source which doesn't have scalar integral mode first convert
            it to outer_mode.

            * gcc.dg/pr108264.c: New test.

    (cherry picked from commit 226a498733e7919de72eb6f1bf3e16883ad159f6)

[Bug middle-end/108264] [11 Regression] ICE compiling guacamole-server on s390x-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.4 as well.