public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "himalr at proton dot me" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/108276] libiberty unlink_if_ordinary does not handle Windows nul device correctly
Date: Wed, 18 Jan 2023 00:53:33 +0000 [thread overview]
Message-ID: <bug-108276-4-4WUObnP81c@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108276-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108276
--- Comment #7 from Himal <himalr at proton dot me> ---
(In reply to niXman from comment #6)
> I think you don't understand me.
>
> with your patch after preprocessing the `unlink_if_ordinary()` will look
> like:
> ```
> int
> unlink_if_ordinary (const char *name)
> {
> if (stricmp (name, "nul") == 0)
> return 1;
>
> return 1;
> }
>
> ```
>
> don't you think it's strange?
Ah, yes. I noticed that after submitting the patch. I have already posted an
updated version
[here](https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609487.html)
prev parent reply other threads:[~2023-01-18 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 17:03 [Bug other/108276] New: " himalr at proton dot me
2023-01-03 17:24 ` [Bug other/108276] " pinskia at gcc dot gnu.org
2023-01-16 16:23 ` i.nixman at autistici dot org
2023-01-16 17:02 ` i.nixman at autistici dot org
2023-01-16 18:28 ` i.nixman at autistici dot org
2023-01-17 1:18 ` himalr at proton dot me
2023-01-17 7:06 ` i.nixman at autistici dot org
2023-01-18 0:53 ` himalr at proton dot me [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-108276-4-4WUObnP81c@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).