From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D08A13858D28; Wed, 18 Jan 2023 00:53:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D08A13858D28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1674003213;
	bh=s+YQsNBSRhpEqwNUNYzmGuD4Y/TOZiTDV1CJMyUFSxc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=YSMNA5XzO9w8LV/RUa/Y1CpQ6QOMbpx+lcKO/aErVhpls6wMWt/J7/QzH/8iidtm3
	 PwTu82L2mpKHkG9Z7+puPKGWL1uE3riRLwQvsgJaLSnNGRWDPAio8RiMo0v8+jqhGq
	 GdXbN00AobWfF+fhhp7+D2T02BQ59Ai2ojZHYzjk=
From: "himalr at proton dot me" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/108276] libiberty unlink_if_ordinary does not handle
 Windows nul device correctly
Date: Wed, 18 Jan 2023 00:53:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: other
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: himalr at proton dot me
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108276-4-4WUObnP81c@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108276-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108276-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108276

--- Comment #7 from Himal <himalr at proton dot me> ---
(In reply to niXman from comment #6)
> I think you don't understand me.
>=20
> with your patch after preprocessing the `unlink_if_ordinary()` will look
> like:
> ```
> int
> unlink_if_ordinary (const char *name)
> {
>   if (stricmp (name, "nul") =3D=3D 0)
>     return 1;
>=20
>   return 1;
> }
>=20
> ```
>=20
> don't you think it's strange?

Ah, yes. I noticed that after submitting the patch. I have already posted an
updated version
[here](https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609487.html)=