public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "nyh at math dot technion.ac.il" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/108296] New: __builtin_memcpy generating wrong code in some cases Date: Thu, 05 Jan 2023 08:37:25 +0000 [thread overview] Message-ID: <bug-108296-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108296 Bug ID: 108296 Summary: __builtin_memcpy generating wrong code in some cases Product: gcc Version: 12.2.1 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: nyh at math dot technion.ac.il Target Milestone: --- The following trivial code, copying a string over itself moved by one byte, shows wrong results for __builtin_memcpy() on gcc 12.2.1: #include <cstring> int main(){ char bufa[128] = "0123456789abcdefghijklmnopqrstuvwxyz"; char bufb[128] = "0123456789abcdefghijklmnopqrstuvwxyz"; memcpy(bufa, bufa+1, 27); printf(" memcpy: %s\n", bufa); __builtin_memcpy(bufb, bufb+1, 27); printf("__builtin_memcpy: %s\n", bufb); } As you can see running it, memcpy() returned the right result, 123456789abcdefghijklmnopqrrstuvwxyz (the first 27 characters shifted back, so "r" is double in the response), but __builtin_memcpy() returned the *wrong* result - 123456789abdefgghijklmnopqrrstuvwxyz (the "c" character disappeared and the "g" is also doubled). This bug was discovered in the OSv project https://github.com/cloudius-systems/osv/issues/1212 with code that doesn't (obviously) call __builtin_memcpy() directly, but rather had a 27-character type being copied and the compiler implemented this copy with a call to __builtin_memcpy(). The original miscompiling code in OSv was something like the following: #include <cstdio> int main(){ char buf[128] = "0123456789abcdefghijklmnopqrstuvwxyz"; struct [[gnu::packed]] data { char x[27]; }; void *p0 = buf; void *p1 = &buf[1]; *static_cast<data*>(p0) = *static_cast<const data*>(p1); printf("%s", buf); } This appears to be a regression - this code did not miscompile in earlier gcc releases.
next reply other threads:[~2023-01-05 8:37 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-05 8:37 nyh at math dot technion.ac.il [this message] 2023-01-05 8:53 ` [Bug c/108296] " pinskia at gcc dot gnu.org 2023-01-05 9:08 ` nyh at math dot technion.ac.il 2023-01-05 11:10 ` jakub at gcc dot gnu.org 2023-01-05 11:14 ` jakub at gcc dot gnu.org 2023-01-09 11:15 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108296-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).