public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/108316] [13 Regression] ICE in maybe_gen_insn via expand_SCATTER_STORE when vectorizing for SVE since r13-2737-g4a773bf2f08656
Date: Wed, 08 Feb 2023 13:40:41 +0000	[thread overview]
Message-ID: <bug-108316-4-NbonXs4Fu2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108316-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108316

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:740a3be7df29b280f39a04c441fd4917af4eef5e

commit r13-5739-g740a3be7df29b280f39a04c441fd4917af4eef5e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Feb 8 13:40:29 2023 +0000

    vect: Check gather/scatter offset types [PR108316]

    The gather/scatter support can over-widen an offset if the target
    requires it, but this relies on using a pattern sequence to add
    the widening conversion.  That failed in the testcase because an
    earlier pattern (bool) took priority.

    I think we should allow patterns to be applied to other patterns,
    but that's quite an invasive change and isn't suitable for stage 4.
    This patch instead punts if the offset type doesn't match the
    expected one.

    If we switched to using the SLP representation for everything,
    we would probably handle both patterns by rewriting the graph,
    which should be much easier.

    gcc/
            PR tree-optimization/108316
            * tree-vect-stmts.cc (get_load_store_type): When using
            internal functions for gather/scatter, make sure that the type
            of the offset argument is consistent with the offset vector type.

    gcc/testsuite/
            PR tree-optimization/108316
            * gcc.dg/vect/pr108316.c: New test.

  parent reply	other threads:[~2023-02-08 13:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 11:42 [Bug target/108316] New: [13 Regression] ICE in maybe_gen_insn via expand_SCATTER_STORE when vectorizing for SVE acoplan at gcc dot gnu.org
2023-01-06 12:18 ` [Bug target/108316] [13 Regression] ICE in maybe_gen_insn via expand_SCATTER_STORE when vectorizing for SVE since r13-2737-g4a773bf2f08656 marxin at gcc dot gnu.org
2023-01-10  7:09 ` rguenth at gcc dot gnu.org
2023-02-06 13:49 ` jakub at gcc dot gnu.org
2023-02-06 15:06 ` jakub at gcc dot gnu.org
2023-02-07 15:31 ` rsandifo at gcc dot gnu.org
2023-02-08 13:40 ` cvs-commit at gcc dot gnu.org [this message]
2023-02-11 15:00 ` [Bug target/108316] " jakub at gcc dot gnu.org
2023-04-26  6:57 ` rguenth at gcc dot gnu.org
2023-07-27  9:25 ` rguenth at gcc dot gnu.org
2024-05-21  9:13 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108316-4-NbonXs4Fu2@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).