From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id F37EE3857C5A; Thu,  5 Oct 2023 18:01:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F37EE3857C5A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1696528907;
	bh=V4zgYdeSUq9rIiC3wAI1P2Kps4dIBragFUZT8fycNmk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Q9RbInreBECIS9NPNgCPtG0zIYQaytZloAItS7OCe/CJzF19x9ATt4n9hCbwuBYqG
	 ZXHuOIbKhFj+7qGqev+/aRuJagJ6xj9S6s4KlLepUt2cxe0PqzUV40k0050Itslyjm
	 3+5byyLyf2m4iFRuj6JSjIQS4/m8FkhsHX4TySYA=
From: "carll at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/108396] [12/13 Regression] PPCLE: vec_vsubcuq missing
 since r12-5752-gd08236359eb229
Date: Thu, 05 Oct 2023 18:01:44 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.2.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: carll at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-108396-4-A2t1kv9uRj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108396-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108396-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108396

Carl Love <carll at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carll at gcc dot gnu.org

--- Comment #9 from Carl Love <carll at gcc dot gnu.org> ---
I made a copy of rs6000-overload.def and then with a series of emacs macros
converted the list of builtins to a script to grep for the builtins in the =
test
directory.  Specifically from rs6000-overload.def:

[BCDADD, __builtin_bcdadd, __builtin_vec_bcdadd]
  vsq __builtin_vec_bcdadd (vsq, vsq, const int);
    BCDADD_V1TI
  vuc __builtin_vec_bcdadd (vuc, vuc, const int);
    BCDADD_V16QI

[BCDADD_EQ, __builtin_bcdadd_eq, __builtin_vec_bcdadd_eq]
  signed int __builtin_vec_bcdadd_eq (vsq, vsq, const int);
    BCDADD_EQ_V1TI
  signed int __builtin_vec_bcdadd_eq (vuc, vuc, const int);
    BCDADD_EQ_V16QI

....

Was converted to the bash script:

rm -f ../test1_not_found=20

NOT_FOUND=3D'0       0       0'
check_name () {
  str1=3D$(grep -r  $1 * | wc)

#  echo " output of command: $str1"

  if [[ "$str1" =3D=3D *"$NOT_FOUND"* ]]; then
    echo "$1 not found" >> ../test1_not_found
  fi
}

check_name "__builtin_bcdadd" "__builtin_vec_bcdadd"

check_name "__builtin_bcdadd_eq" "__builtin_vec_bcdadd_eq"

....

The script is passed the user built-in name ($str1) and the internal built-=
in
name ($str2).  I ran the script in directory gcc/testsuite/gcc.target/power=
pc
and it identified two tests ($str1) as not showing up in a test file.  The
tests were:  __builtin_bcdsub_ge and __builtin_bcdsub_le.

I figure if the first builtin name has a test associated with it that shoul=
d be
sufficient.  I will create a patch to add testcases for the two missing
builtin-names.

I did add to the script to see how many definitions have a test for the
built-in name $1 but not the built-in name $2 doesn't show up in a test fil=
e.=20
My script identified 86 of these cases.  Not sure that we really need to add
test cases for the internal builtin name ($str).  Thoughts?=