From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id EE51F3858C30; Thu, 12 Oct 2023 06:10:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE51F3858C30
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1697091031;
	bh=naZxl7xB9WTyv9CTvubXbajKnZvXS+nZsdrwB/7I3oA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=DLHS9sipU50VNxgmFCW5ON44OZh8iv0iGNtO+kYIp1M4VdTvdky/4WZRCqu7mMHMs
	 M66LorjrIzSKmrEbPKwu8hPTZkUwLePsZpwZyjkoBza3phGENEEKVxgAm4agI3cB5v
	 pnH9gIcxUvmfnH+FuI+c9cP81kaYR+pa6Gxg5SMY=
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/108396] [12/13 Regression] PPCLE: vec_vsubcuq missing
 since r12-5752-gd08236359eb229
Date: Thu, 12 Oct 2023 06:10:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.2.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: linkw at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108396-4-a9UEHONBT4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108396-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108396-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108396

--- Comment #10 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Carl Love from comment #9)
> I made a copy of rs6000-overload.def and then with a series of emacs macr=
os
> converted the list of builtins to a script to grep for the builtins in the
> test directory.  Specifically from rs6000-overload.def:
>=20
> [BCDADD, __builtin_bcdadd, __builtin_vec_bcdadd]
>   vsq __builtin_vec_bcdadd (vsq, vsq, const int);
>     BCDADD_V1TI
>   vuc __builtin_vec_bcdadd (vuc, vuc, const int);
>     BCDADD_V16QI
>=20
> [BCDADD_EQ, __builtin_bcdadd_eq, __builtin_vec_bcdadd_eq]
>   signed int __builtin_vec_bcdadd_eq (vsq, vsq, const int);
>     BCDADD_EQ_V1TI
>   signed int __builtin_vec_bcdadd_eq (vuc, vuc, const int);
>     BCDADD_EQ_V16QI
>=20
> ....
>=20
> Was converted to the bash script:
>=20
> rm -f ../test1_not_found=20
>=20
> NOT_FOUND=3D'0       0       0'
> check_name () {
>   str1=3D$(grep -r  $1 * | wc)
>=20
> #  echo " output of command: $str1"
>=20
>   if [[ "$str1" =3D=3D *"$NOT_FOUND"* ]]; then
>     echo "$1 not found"	>> ../test1_not_found
>   fi
> }
>=20
> check_name "__builtin_bcdadd" "__builtin_vec_bcdadd"
>=20
> check_name "__builtin_bcdadd_eq" "__builtin_vec_bcdadd_eq"
>=20
> ....
>=20=20
> The script is passed the user built-in name ($str1) and the internal
> built-in name ($str2).  I ran the script in directory
> gcc/testsuite/gcc.target/powerpc
> and it identified two tests ($str1) as not showing up in a test file.  The
> tests were:  __builtin_bcdsub_ge and __builtin_bcdsub_le.
>=20
> I figure if the first builtin name has a test associated with it that sho=
uld
> be sufficient.  I will create a patch to add testcases for the two missing
> builtin-names.
>=20
> I did add to the script to see how many definitions have a test for the
> built-in name $1 but not the built-in name $2 doesn't show up in a test
> file.  My script identified 86 of these cases.  Not sure that we really n=
eed
> to add test cases for the internal builtin name ($str).  Thoughts?

Thanks for tracking this!  As you said, I think checking the name $1 is
sufficient since only those are visible for users. btw, since this is close=
d,
let us discuss it on the internal issue further. :)=